You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/21 14:59:55 UTC
[GitHub] [apisix-dashboard] wmdmomo opened a new pull request #1990: feat(plugin): fix UI limit-conn
wmdmomo opened a new pull request #1990:
URL: https://github.com/apache/apisix-dashboard/pull/1990
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [ ] Bugfix
- [ ] New feature provided
- [x] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
The PR will change the plugin under plugin/UI (limit-conn), allowing limit-conn to dynamically adapt to the back-end json rules.
**Related issues**
fix/resolve #1588
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [x] Have you added corresponding test cases?
- [x] Have you modified the corresponding document?
- [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] wmdmomo removed a comment on pull request #1990: feat(plugin): allowing limit-conn to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
wmdmomo removed a comment on pull request #1990:
URL: https://github.com/apache/apisix-dashboard/pull/1990#issuecomment-894795160
> @wmdmomo please fix conflict files when you have time thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1990: feat(plugin): allowing limit-conn to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #1990:
URL: https://github.com/apache/apisix-dashboard/pull/1990#issuecomment-894583729
@wmdmomo please fix conflict files when you have time thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1990: feat(plugin): fix UI limit-conn
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1990:
URL: https://github.com/apache/apisix-dashboard/pull/1990#issuecomment-884258758
π· Deploy Preview for *apisix-dashboard* processing.
π¨ Explore the source changes: e90daa7ec766b5aa2f8fa1ed6e8b2f9d5a49f6a3
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60f8365d8adcbb000882c3fb](https://app.netlify.com/sites/apisix-dashboard/deploys/60f8365d8adcbb000882c3fb?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun merged pull request #1990: feat(plugin): allowing limit-conn to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
LiteSun merged pull request #1990:
URL: https://github.com/apache/apisix-dashboard/pull/1990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1990: feat(plugin): allowing limit-conn to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1990:
URL: https://github.com/apache/apisix-dashboard/pull/1990#issuecomment-884258758
π· Deploy Preview for *apisix-dashboard* processing.
π¨ Explore the source changes: 2015ae763d17efeb2f77ef30f32a251e19bf22fa
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/610fd86c3cbf7000078ad1d6](https://app.netlify.com/sites/apisix-dashboard/deploys/610fd86c3cbf7000078ad1d6?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1990: feat(plugin): allowing limit-conn to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1990:
URL: https://github.com/apache/apisix-dashboard/pull/1990#issuecomment-884258758
βοΈ Deploy Preview for *apisix-dashboard* ready!
π¨ Explore the source changes: 2015ae763d17efeb2f77ef30f32a251e19bf22fa
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/610fd86c3cbf7000078ad1d6](https://app.netlify.com/sites/apisix-dashboard/deploys/610fd86c3cbf7000078ad1d6?utm_source=github&utm_campaign=bot_dl)
π Browse the preview: [https://deploy-preview-1990--apisix-dashboard.netlify.app/](https://deploy-preview-1990--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] wmdmomo commented on pull request #1990: feat(plugin): allowing limit-conn to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
wmdmomo commented on pull request #1990:
URL: https://github.com/apache/apisix-dashboard/pull/1990#issuecomment-894795160
> @wmdmomo please fix conflict files when you have time thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] wmdmomo commented on pull request #1990: feat(plugin): allowing limit-conn to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
wmdmomo commented on pull request #1990:
URL: https://github.com/apache/apisix-dashboard/pull/1990#issuecomment-894794700
> @wmdmomo please fix conflict files when you have time thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1990: feat(plugin): allowing limit-conn to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1990:
URL: https://github.com/apache/apisix-dashboard/pull/1990#issuecomment-885380945
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1990?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1990](https://codecov.io/gh/apache/apisix-dashboard/pull/1990?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2015ae7) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/5a581d3f0fa0f74a634af93f14fc779c16454938?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a581d3) will **increase** coverage by `0.07%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1990?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1990 +/- ##
==========================================
+ Coverage 65.69% 65.77% +0.07%
==========================================
Files 121 121
Lines 3204 3205 +1
Branches 778 778
==========================================
+ Hits 2105 2108 +3
+ Misses 1099 1097 -2
```
| Flag | Coverage Ξ | |
|---|---|---|
| frontend-e2e-test | `65.77% <100.00%> (+0.07%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1990?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [web/src/components/Plugin/UI/limit-conn.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1jb25uLnRzeA==) | `100.00% <100.00%> (ΓΈ)` | |
| [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `83.33% <100.00%> (ΓΈ)` | |
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `72.13% <0.00%> (+3.27%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1990?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1990?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5a581d3...2015ae7](https://codecov.io/gh/apache/apisix-dashboard/pull/1990?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1990: feat(plugin): fix UI limit-conn
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1990:
URL: https://github.com/apache/apisix-dashboard/pull/1990#issuecomment-884258758
βοΈ Deploy Preview for *apisix-dashboard* ready!
π¨ Explore the source changes: e90daa7ec766b5aa2f8fa1ed6e8b2f9d5a49f6a3
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60f8365d8adcbb000882c3fb](https://app.netlify.com/sites/apisix-dashboard/deploys/60f8365d8adcbb000882c3fb?utm_source=github&utm_campaign=bot_dl)
π Browse the preview: [https://deploy-preview-1990--apisix-dashboard.netlify.app/](https://deploy-preview-1990--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] wmdmomo closed pull request #1990: feat(plugin): allowing limit-conn to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
wmdmomo closed pull request #1990:
URL: https://github.com/apache/apisix-dashboard/pull/1990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] wmdmomo removed a comment on pull request #1990: feat(plugin): allowing limit-conn to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
wmdmomo removed a comment on pull request #1990:
URL: https://github.com/apache/apisix-dashboard/pull/1990#issuecomment-894794700
> @wmdmomo please fix conflict files when you have time thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1990: feat(plugin): fix UI limit-conn
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1990:
URL: https://github.com/apache/apisix-dashboard/pull/1990#issuecomment-885380945
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1990?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1990](https://codecov.io/gh/apache/apisix-dashboard/pull/1990?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e90daa7) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/799e69aa9e4017db7b50f430f11cf0bad990a9bc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (799e69a) will **increase** coverage by `0.08%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1990?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1990 +/- ##
==========================================
+ Coverage 63.95% 64.03% +0.08%
==========================================
Files 122 122
Lines 3154 3156 +2
Branches 753 753
==========================================
+ Hits 2017 2021 +4
+ Misses 1137 1135 -2
```
| Flag | Coverage Ξ | |
|---|---|---|
| frontend-e2e-test | `64.03% <100.00%> (+0.08%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1990?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `65.82% <100.00%> (+0.21%)` | :arrow_up: |
| [web/src/components/Plugin/UI/limit-conn.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1jb25uLnRzeA==) | `100.00% <100.00%> (ΓΈ)` | |
| [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `82.60% <100.00%> (ΓΈ)` | |
| [web/src/pages/Consumer/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9DcmVhdGUudHN4) | `76.08% <0.00%> (ΓΈ)` | |
| [web/src/components/Upstream/components/Nodes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvTm9kZXMudHN4) | `100.00% <0.00%> (ΓΈ)` | |
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `72.13% <0.00%> (+3.27%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1990?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1990?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [799e69a...e90daa7](https://codecov.io/gh/apache/apisix-dashboard/pull/1990?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] wmdmomo commented on pull request #1990: feat(plugin): allowing limit-conn to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
wmdmomo commented on pull request #1990:
URL: https://github.com/apache/apisix-dashboard/pull/1990#issuecomment-894795758
@liuxiran I have resolved the conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org