You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by kennknowles <gi...@git.apache.org> on 2017/04/04 17:25:11 UTC

[GitHub] beam pull request #2425: Rename filePath to filePattern in NumbedShardedFile

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/2425

    Rename filePath to filePattern in NumbedShardedFile

    R: @reuvenlax @tgroh 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam fileGlob

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2425.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2425
    
----
commit 797f4f8bc3bf69e630753f0219e220a8a9d80e2d
Author: Kenneth Knowles <kl...@google.com>
Date:   2017-04-04T17:23:54Z

    Rename filePath to filePattern in NumbedShardedFile
    
    This probably would have saved a few hours of debugging by
    signposting the intended usage more clearly.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #2425: Rename filePath to filePattern in NumbedShardedFile

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/2425


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---