You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/07/17 22:26:08 UTC

[GitHub] [airflow] tvalentyn commented on a change in pull request #5602: [AIRFLOW-4983] Feature/dataflow operator python3

tvalentyn commented on a change in pull request #5602: [AIRFLOW-4983] Feature/dataflow operator python3
URL: https://github.com/apache/airflow/pull/5602#discussion_r304667766
 
 

 ##########
 File path: airflow/contrib/hooks/gcp_dataflow_hook.py
 ##########
 @@ -34,8 +34,12 @@
 
 # This is the default location
 # https://cloud.google.com/dataflow/pipelines/specifying-exec-params
+
 DEFAULT_DATAFLOW_LOCATION = 'us-central1'
 
+# These are the supported python interpreters
+DATAFLOW_SUPPORTED_PY_INTERPRETERS = {'python2', 'python3'}
 
 Review comment:
   I am not familiar with airflow, but wondering if we should also include `python`, `python3.5`, `python3.6`, `python3.7` if users wish to have less or more control as to which interpreter to choose.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services