You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/01/13 14:52:20 UTC

[GitHub] [activemq-artemis] clebertsuconic opened a new pull request #2936: NO-JIRA Adding test name into temporary folder name directory

clebertsuconic opened a new pull request #2936: NO-JIRA Adding test name into temporary folder name directory
URL: https://github.com/apache/activemq-artemis/pull/2936
 
 
   This is to make it possible to identify what test is leaking files whenever that is happening.
   That is because future tests will report the leaks, and it's difficult to identify where it happened.
   
   Also i'm changing NoProcessFilesBehind to show the getOpenFD propertly

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] jbertram commented on issue #2936: NO-JIRA Adding test name into temporary folder name directory

Posted by GitBox <gi...@apache.org>.
jbertram commented on issue #2936: NO-JIRA Adding test name into temporary folder name directory
URL: https://github.com/apache/activemq-artemis/pull/2936#issuecomment-573724577
 
 
   Nice one!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] asfgit merged pull request #2936: NO-JIRA Adding test name into temporary folder name directory

Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #2936: NO-JIRA Adding test name into temporary folder name directory
URL: https://github.com/apache/activemq-artemis/pull/2936
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] asfgit merged pull request #2936: NO-JIRA Adding test name into temporary folder name directory

Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #2936: NO-JIRA Adding test name into temporary folder name directory
URL: https://github.com/apache/activemq-artemis/pull/2936
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2936: NO-JIRA Adding test name into temporary folder name directory

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on issue #2936: NO-JIRA Adding test name into temporary folder name directory
URL: https://github.com/apache/activemq-artemis/pull/2936#issuecomment-573701975
 
 
   These files will be removed by another rule in ActiveMQTestBase:
   
   https://github.com/apache/activemq-artemis/blob/3fff744de4d0ba3b209c821cc1404d920455157c/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java#L233-L236
   
   
   I had a case where I had leaks on a change I made, and I needed this to find the issue.
   
   I wanted to keep this a permanent change as it will be helpful in the future.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services