[GitHub] wohali commented on issue #1160: Add support for Bcrypt password hashing

[GitBox <gi...@apache.org>]

wohali commented on issue #1160: Add support for Bcrypt password hashing
URL: https://github.com/apache/couchdb/pull/1160#issuecomment-365130428
 
 
   For Apache CouchDB to accept this code, we will need to import the erlangpack/bcrypt repo and perform due diligence on the [LICENSE](https://github.com/erlangpack/bcrypt/blob/master/LICENSE) file. At a glance, it looks OK - just saying that this won't hit `master` with a non-Apache hosted repo in `rebar.config`. This likely means your code would need to be merged to a feature branch, and have the stated concern worked there, before it would be merged to `master`.
   
   I can't speak to the desirability or the technical efficacy of the patch; someone else will need to comment. I know there have been arguments on bcrypt vs. pbkdf2 in the past, but I can't remember where they went.
   
   What motivated this work?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services