You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Zoltan Haindrich <ki...@rxd.hu> on 2017/09/19 13:38:40 UTC

Review Request 62407: HIVE-17378 CBO: HiveReduceExpressionsWithStatsRule can operate on IS_NULL and IS_NOT_NULL

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62407/
-----------------------------------------------------------

Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez.


Bugs: HIVE-17378
    https://issues.apache.org/jira/browse/HIVE-17378


Repository: hive-git


Description
-------

add IS_NULL / IS_NOT_NULL support


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsWithStatsRule.java 6e900b3bfe912cf5e8d6af9574153b318aed8c7a 
  ql/src/test/org/apache/hadoop/hive/ql/optimizer/calcite/rules/TestHiveReduceExpressionsWithStatsRule.java PRE-CREATION 
  ql/src/test/queries/clientpositive/remove_exprs_stats.q 66e6615047a6d37ff1e67c99d295dcde07240d8e 
  ql/src/test/results/clientpositive/remove_exprs_stats.q.out 4600e71f09430af9f785594faff2d80d2a1f86a9 


Diff: https://reviews.apache.org/r/62407/diff/1/


Testing
-------

unit test+qtest


Thanks,

Zoltan Haindrich


Re: Review Request 62407: HIVE-17378 CBO: HiveReduceExpressionsWithStatsRule can operate on IS_NULL and IS_NOT_NULL

Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62407/#review185772
-----------------------------------------------------------



Changes LGTM.

- Jesús Camacho Rodríguez


On Sept. 19, 2017, 1:38 p.m., Zoltan Haindrich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62407/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2017, 1:38 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez.
> 
> 
> Bugs: HIVE-17378
>     https://issues.apache.org/jira/browse/HIVE-17378
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> add IS_NULL / IS_NOT_NULL support
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsWithStatsRule.java 6e900b3bfe912cf5e8d6af9574153b318aed8c7a 
>   ql/src/test/org/apache/hadoop/hive/ql/optimizer/calcite/rules/TestHiveReduceExpressionsWithStatsRule.java PRE-CREATION 
>   ql/src/test/queries/clientpositive/remove_exprs_stats.q 66e6615047a6d37ff1e67c99d295dcde07240d8e 
>   ql/src/test/results/clientpositive/remove_exprs_stats.q.out 4600e71f09430af9f785594faff2d80d2a1f86a9 
> 
> 
> Diff: https://reviews.apache.org/r/62407/diff/1/
> 
> 
> Testing
> -------
> 
> unit test+qtest
> 
> 
> Thanks,
> 
> Zoltan Haindrich
> 
>