You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Jakob Homan (JIRA)" <ji...@apache.org> on 2008/07/16 04:31:31 UTC
[jira] Created: (ZOOKEEPER-76) Commit 677109 removed the cobertura
library, but not the build targets.
Commit 677109 removed the cobertura library, but not the build targets.
-----------------------------------------------------------------------
Key: ZOOKEEPER-76
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-76
Project: Zookeeper
Issue Type: Bug
Components: build
Reporter: Jakob Homan
Attachments: delcobertura.patch
Cobertura library removed due to licensing issues, but the code-coverage ant targets were left in. Have deleted them and created patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-76) Commit 677109 removed the cobertura
library, but not the build targets.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-76:
----------------------------------
Resolution: Invalid
Assignee: Patrick Hunt
Status: Resolved (was: Patch Available)
Thanks for the patch and the feedback, however this was intentional. Notice that I added a README.txt in the lib/cobertura directory directing ppl how to d/l cobertura and run the build target.
After moving to Apache committers have access to an Apache license for Clover however contributors (non-comitters) do not. I left this target in place to allow anyone access to a coverage tool.
> Commit 677109 removed the cobertura library, but not the build targets.
> -----------------------------------------------------------------------
>
> Key: ZOOKEEPER-76
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-76
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Reporter: Jakob Homan
> Assignee: Patrick Hunt
> Attachments: delcobertura.patch
>
>
> Cobertura library removed due to licensing issues, but the code-coverage ant targets were left in. Have deleted them and created patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-76) Commit 677109 removed the cobertura
library, but not the build targets.
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated ZOOKEEPER-76:
---------------------------------
Attachment: delcobertura.patch
> Commit 677109 removed the cobertura library, but not the build targets.
> -----------------------------------------------------------------------
>
> Key: ZOOKEEPER-76
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-76
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Reporter: Jakob Homan
> Attachments: delcobertura.patch
>
>
> Cobertura library removed due to licensing issues, but the code-coverage ant targets were left in. Have deleted them and created patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-76) Commit 677109 removed the cobertura
library, but not the build targets.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-76:
----------------------------------
Attachment: ZOOKEEPER-76.patch
This patch (ZOOKEEPER-76.patch) pushes the taskdef into the target, so it won't be run unless one of the cobertura targets is specifically run (then obv the jar needs to be in place).
Please review/vote and I will commit.
> Commit 677109 removed the cobertura library, but not the build targets.
> -----------------------------------------------------------------------
>
> Key: ZOOKEEPER-76
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-76
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Reporter: Jakob Homan
> Assignee: Patrick Hunt
> Attachments: delcobertura.patch, ZOOKEEPER-76.patch, Zookeeper-76_1.patch
>
>
> Cobertura library removed due to licensing issues, but the code-coverage ant targets were left in. Have deleted them and created patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-76) Commit 677109 removed the cobertura
library, but not the build targets.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-76:
-----------------------------------
Attachment: Zookeeper-76_1.patch
i just did this as in the patch which amkes the tests work fine. -- getting rid of cobertura in the classpath.
> Commit 677109 removed the cobertura library, but not the build targets.
> -----------------------------------------------------------------------
>
> Key: ZOOKEEPER-76
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-76
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Reporter: Jakob Homan
> Assignee: Patrick Hunt
> Attachments: delcobertura.patch, Zookeeper-76_1.patch
>
>
> Cobertura library removed due to licensing issues, but the code-coverage ant targets were left in. Have deleted them and created patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ZOOKEEPER-76) Commit 677109 removed the cobertura
library, but not the build targets.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt resolved ZOOKEEPER-76.
-----------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
Hadoop Flags: [Reviewed]
Fixed in 677371 using ZOOKEEPER-76.patch
> Commit 677109 removed the cobertura library, but not the build targets.
> -----------------------------------------------------------------------
>
> Key: ZOOKEEPER-76
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-76
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Reporter: Jakob Homan
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: delcobertura.patch, ZOOKEEPER-76.patch, Zookeeper-76_1.patch
>
>
> Cobertura library removed due to licensing issues, but the code-coverage ant targets were left in. Have deleted them and created patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-76) Commit 677109 removed the
cobertura library, but not the build targets.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614056#action_12614056 ]
Mahadev konar commented on ZOOKEEPER-76:
----------------------------------------
pats patch seems better.. +1 on pat's patch ...
> Commit 677109 removed the cobertura library, but not the build targets.
> -----------------------------------------------------------------------
>
> Key: ZOOKEEPER-76
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-76
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Reporter: Jakob Homan
> Assignee: Patrick Hunt
> Attachments: delcobertura.patch, ZOOKEEPER-76.patch, Zookeeper-76_1.patch
>
>
> Cobertura library removed due to licensing issues, but the code-coverage ant targets were left in. Have deleted them and created patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (ZOOKEEPER-76) Commit 677109 removed the cobertura
library, but not the build targets.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reopened ZOOKEEPER-76:
-----------------------------------
Hrm. For whatever reason the build was successful before the commit, however now it's failing due to not being able to find cobertura jar. (I had run the test target successfully on the patch, weird).
I'm reopening this to see if I can fix (otw I'll apply the submitted patch).
> Commit 677109 removed the cobertura library, but not the build targets.
> -----------------------------------------------------------------------
>
> Key: ZOOKEEPER-76
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-76
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Reporter: Jakob Homan
> Assignee: Patrick Hunt
> Attachments: delcobertura.patch
>
>
> Cobertura library removed due to licensing issues, but the code-coverage ant targets were left in. Have deleted them and created patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-76) Commit 677109 removed the cobertura
library, but not the build targets.
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated ZOOKEEPER-76:
---------------------------------
Status: Patch Available (was: Open)
Deletes code coverage build targets
> Commit 677109 removed the cobertura library, but not the build targets.
> -----------------------------------------------------------------------
>
> Key: ZOOKEEPER-76
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-76
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Reporter: Jakob Homan
> Attachments: delcobertura.patch
>
>
> Cobertura library removed due to licensing issues, but the code-coverage ant targets were left in. Have deleted them and created patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.