You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/07/21 10:31:04 UTC

[jira] [Commented] (THRIFT-3251) Add http transport for server to Go lib

    [ https://issues.apache.org/jira/browse/THRIFT-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634764#comment-14634764 ] 

ASF GitHub Bot commented on THRIFT-3251:
----------------------------------------

GitHub user hhkbp2 opened a pull request:

    https://github.com/apache/thrift/pull/557

    Thrift 3251 Add http transport for server to Go lib

    Hi,
    
    This PR is a reopen for previous PR #556, in order to follow our how to contribute guide.
    
    It adds http transport for server to Go lib.
    For more info please refer to Jira
    [https://issues.apache.org/jira/browse/THRIFT-3251](https://issues.apache.org/jira/browse/THRIFT-3251)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hhkbp2/thrift THRIFT-3251

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/557.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #557
    
----
commit ebb6d04f1f59818a19525123d32bd64f163063fe
Author: Dylan.Wen <hh...@gmail.com>
Date:   2015-07-07T10:25:14Z

    add http transport implementation for golang server

commit 6c318e50adba846d9d0a0794a0f2d217ecdcb507
Author: Dylan.Wen <hh...@gmail.com>
Date:   2015-07-08T06:20:34Z

    add test for golang http transport

commit b1e4bb7db9af82bd078cfaaf67df27a3fb72e108
Author: Dylan.Wen <hh...@gmail.com>
Date:   2015-07-08T08:38:39Z

    simplify the used interfaces a little bit

----


> Add http transport for server to Go lib
> ---------------------------------------
>
>                 Key: THRIFT-3251
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3251
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Go - Library
>    Affects Versions: 0.9.2
>            Reporter: Dylan Wen
>            Priority: Minor
>
> There is a lack of http transport for server in Go lib, so the server could not communicate with client running http transport, e.g., client runs the Go code  lib/go/thrift/http_client.go, or C++ async client which usually runs along with libevent and http transport.
> Some code similar to lib/cpp/src/thrift/transport/THttpTransport.cpp needs to be added to Go lib, in order to run a server written in Go to communicate with these http transport client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)