You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2016/12/17 14:29:14 UTC
[Issue 127252] New: All of AOO doesn't handle C++ exceptions
properly, making Clang unusable
https://bz.apache.org/ooo/show_bug.cgi?id=127252
Issue ID: 127252
Issue Type: DEFECT
Summary: All of AOO doesn't handle C++ exceptions properly,
making Clang unusable
Product: Build Tools
Version: 4.2.0-dev
Hardware: All
OS: Other OS
Status: CONFIRMED
Severity: Major
Priority: P5 (lowest)
Component: code
Assignee: issues@openoffice.apache.org
Reporter: damjan@apache.org
Target Milestone: ---
A lot of C++ code in AOO doesn't follow the C++ specifications when handling
exceptions, for example exceptions are thrown without being declared in the
function's prototype, which SHOULD result in a call to unexpected() and
termination of the application.
AOO however hides this fact using the -fno-enforce-eh-specs flag to GCC on
Linux (see main/solenv/gbuild/platform/linux.mk), and something similar on
Windows, so those platforms and compilers don't end up in unexpected() and
there is no crash. Clang, used on at least MacOS and FreeBSD, doesn't support
that flag, so they will crash in cases where Windows and Linux don't, making
those platforms DANGEROUSLY UNSTABLE!!!
See bug 125868 and its fix in commit 1765488 for a real world example. *Many*
more cases could exist!
Unless support can be added to Clang, a thorough audit of all code in AOO will
be needed to find and fix all the exception handling. Hopefully there's a way
to automate it somehow.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127252] All of AOO doesn't handle C++ exceptions properly,
making Clang unusable
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127252
Matthias Seidel <ms...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|lisamathew8076@gmail.com |
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127252] All of AOO doesn't handle C++ exceptions properly,
making Clang unusable
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127252
--- Comment #10 from positivequotes45 <mo...@gmail.com> ---
we must seek in life. We are the people with different Conscience but the same
Consciousness and when we become identified with it, we find the connecting
chords of the cosmos and get to know that we are not separate from anything in
existence. Wisdom is power (subjectively), and power is best shared among us.
https://www.wordsaregod.com/
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127252] All of AOO doesn't handle C++ exceptions properly,
making Clang unusable
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127252
M Travis <tr...@g.ucla.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |travism1@g.ucla.edu
--- Comment #3 from M Travis <tr...@g.ucla.edu> ---
For reference, here is the encyclopedia entry for Clang
https://www.everipedia.com/Clang/
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127252] All of AOO doesn't handle C++ exceptions properly,
making Clang unusable
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127252
--- Comment #8 from ReviewsonTop <ta...@gmail.com> ---
Reviews on Top is the Tech Circuit for all Gadget News and Reviews. We tell you
about the Latest Tech News and Reviews, Gadget News and Launches, Latest Mobile
Phones, Best Selling Cars, Phone Leaks, Top 10 Selling Laptops & More. Our team
brings your daily dose of all leaks and talks of Tech
News.https://www.reviewsontop.com/ , Tech Circuit for Tech Leaks and News.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127252] All of AOO doesn't handle C++ exceptions properly,
making Clang unusable
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127252
Matthias Seidel <ms...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|motivationalquotes17615@gma |
|il.com |
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127252] All of AOO doesn't handle C++ exceptions properly,
making Clang unusable
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127252
Marcus <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|mayankbisht4114@gmail.com |
--- Comment #7 from Marcus <ma...@apache.org> ---
The last comment is spam - please ignore.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127252] All of AOO doesn't handle C++ exceptions properly,
making Clang unusable
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127252
--- Comment #11 from Matthias Seidel <ms...@apache.org> ---
Another Spam comment!
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127252] All of AOO doesn't handle C++ exceptions properly,
making Clang unusable
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127252
ReviewsonTop <ta...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |taraj0612@gmail.com
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127252] All of AOO doesn't handle C++ exceptions properly,
making Clang unusable
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127252
Matthias Seidel <ms...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mseidel@apache.org
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127252] All of AOO doesn't handle C++ exceptions properly,
making Clang unusable
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127252
positivequotes45 <mo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |motivationalquotes17615@gma
| |il.com
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127252] All of AOO doesn't handle C++ exceptions properly,
making Clang unusable
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127252
--- Comment #9 from Matthias Seidel <ms...@apache.org> ---
Spam again!
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127252] All of AOO doesn't handle C++ exceptions properly,
making Clang unusable
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127252
--- Comment #5 from Matthias Seidel <ms...@apache.org> ---
(In reply to Interior designing software from comment #4)
> Find and compare interior design software. Draw the plan of your home or
> office, test furniture layouts and visit the results in 3D.
> https://www.techjockey.com/category/interior-designing-software
SPAM!
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127252] All of AOO doesn't handle C++ exceptions properly,
making Clang unusable
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127252
Interior designing software <li...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lisamathew8076@gmail.com
--- Comment #4 from Interior designing software <li...@gmail.com> ---
Find and compare interior design software. Draw the plan of your home or
office, test furniture layouts and visit the results in 3D.
https://www.techjockey.com/category/interior-designing-software
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127252] All of AOO doesn't handle C++ exceptions properly,
making Clang unusable
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127252
Pedro Giffuni <pf...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pfg@apache.org
--- Comment #1 from Pedro Giffuni <pf...@apache.org> ---
(In reply to damjan from comment #0)
> A lot of C++ code in AOO doesn't follow the C++ specifications when handling
> exceptions, for example exceptions are thrown without being declared in the
> function's prototype, which SHOULD result in a call to unexpected() and
> termination of the application.
>
Interesting, thanks!
> AOO however hides this fact using the -fno-enforce-eh-specs flag to GCC on
> Linux (see main/solenv/gbuild/platform/linux.mk), and something similar on
> Windows, so those platforms and compilers don't end up in unexpected() and
> there is no crash. Clang, used on at least MacOS and FreeBSD, doesn't
> support that flag, so they will crash in cases where Windows and Linux
> don't, making those platforms DANGEROUSLY UNSTABLE!!!
>
> See bug 125868 and its fix in commit 1765488 for a real world example.
> *Many* more cases could exist!
>
Perhaps opengrok'ing throw(), but I see almost 7000 occurrences ?
> Unless support can be added to Clang, a thorough audit of all code in AOO
> will be needed to find and fix all the exception handling. Hopefully there's
> a way to automate it somehow.
There was a small discussion in Nov 2012 in the clang lists:
http://clang-developers.42468.n3.nabble.com/Does-clang-support-fno-enforce-eh-specs-option-of-gcc-td4028196.html
I don't think clang will be adding support for it. A clang plugin would be
extremely interesting for other projects as well (but I don't know how to use
them).
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127252] All of AOO doesn't handle C++ exceptions properly,
making Clang unusable
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127252
--- Comment #2 from Pedro Giffuni <pf...@apache.org> ---
For the record, according a to a discussion in the LO lists (no code included):
http://libreoffice.freedesktop.narkive.com/fN3eXlzR/exception-specifications-on-functions-useless
The following file needs to be checked:
main/vbahelper/inc/vbahelper/vbaaccesshelper.hxx
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127252] All of AOO doesn't handle C++ exceptions properly,
making Clang unusable
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127252
Lucky patcher <ma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mayankbisht4114@gmail.com
--- Comment #6 from Lucky patcher <ma...@gmail.com> ---
Nobody like to pay for advance features of any games don't like to spend money
on uc, gems and all. We so irritate if we see any ads while playing game and
watching videos. So here i am with a solution of all the problem name as Lucky
patcher. Lucky patcher is famous mods app till now which give you advantage to
crack any game license, block ads and allow you to remove unwanted apps from
your phone. Click now on <a
href="https://www.fabtechie.com/change-your-gaming-experience-with-lucky-patcher/">lucky
patcher</a> to download apk and tutorial how to use it.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127252] All of AOO doesn't handle C++ exceptions properly,
making Clang unusable
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127252
Matthias Seidel <ms...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|taraj0612@gmail.com |
--
You are receiving this mail because:
You are the assignee for the issue.