[GitHub] ocket8888 commented on a change in pull request #3192: Fix trafficops python client installation

[GitBox <gi...@apache.org>]

ocket8888 commented on a change in pull request #3192: Fix trafficops python client installation
URL: https://github.com/apache/trafficcontrol/pull/3192#discussion_r245828007
 
 

 ##########
 File path: traffic_control/clients/python/trafficops/__init__.py
 ##########
 @@ -14,6 +14,8 @@
 # limitations under the License.
 #
 
+from .__version__ import __version__
+
 # Import Local Modules into the 'trafficops' package namespace for convenience.
 from .tosession import TOSession
 from .restapi import InvalidJSONError, LoginError, OperationError, api_request, RestApiSession
 
 Review comment:
   what might be better is removing these bits. If you do that, it shouldn't require anything to be imported to get to the version, which stays in one place at the package level. The cost is that you can't really get much else into the current namespace when you do `from trafficops import *` which is honestly something you shouldn't do anyway, because it clobbers.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services