You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Simon Willnauer (Created) (JIRA)" <ji...@apache.org> on 2011/11/01 15:05:32 UTC
[jira] [Created] (LUCENE-3548) CharsRef#append broken on trunk &
3.x
CharsRef#append broken on trunk & 3.x
-------------------------------------
Key: LUCENE-3548
URL: https://issues.apache.org/jira/browse/LUCENE-3548
Project: Lucene - Java
Issue Type: Bug
Components: core/other
Affects Versions: 3.4, 3.5, 4.0
Reporter: Simon Willnauer
Fix For: 3.5, 4.0
Current impl. for append on CharsRef is broken - it overrides the actual content rather than append. its used in many places especially in solr so we might have some broken
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Assigned] (LUCENE-3548) CharsRef#append broken on trunk &
3.x
Posted by "Simon Willnauer (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer reassigned LUCENE-3548:
---------------------------------------
Assignee: Simon Willnauer
> CharsRef#append broken on trunk & 3.x
> -------------------------------------
>
> Key: LUCENE-3548
> URL: https://issues.apache.org/jira/browse/LUCENE-3548
> Project: Lucene - Java
> Issue Type: Bug
> Components: core/other
> Affects Versions: 3.4, 3.5, 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Fix For: 3.5, 4.0
>
> Attachments: LUCENE-3548.patch
>
>
> Current impl. for append on CharsRef is broken - it overrides the actual content rather than append. its used in many places especially in solr so we might have some broken
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3548) CharsRef#append broken on trunk &
3.x
Posted by "Simon Willnauer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer updated LUCENE-3548:
------------------------------------
Attachment: LUCENE-3548.patch
here is a patch
> CharsRef#append broken on trunk & 3.x
> -------------------------------------
>
> Key: LUCENE-3548
> URL: https://issues.apache.org/jira/browse/LUCENE-3548
> Project: Lucene - Java
> Issue Type: Bug
> Components: core/other
> Affects Versions: 3.4, 3.5, 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Fix For: 3.5, 4.0
>
> Attachments: LUCENE-3548.patch
>
>
> Current impl. for append on CharsRef is broken - it overrides the actual content rather than append. its used in many places especially in solr so we might have some broken
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3548) CharsRef#append broken on trunk &
3.x
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141186#comment-13141186 ]
Robert Muir commented on LUCENE-3548:
-------------------------------------
while we are at it, maybe we should look at LUCENE-3277?
I listed a few more things there.
In my opinion the best thing we could do would be to have consistent Bytes/Chars/Ints/LongsRef apis
where all the methods have the same semantics!
> CharsRef#append broken on trunk & 3.x
> -------------------------------------
>
> Key: LUCENE-3548
> URL: https://issues.apache.org/jira/browse/LUCENE-3548
> Project: Lucene - Java
> Issue Type: Bug
> Components: core/other
> Affects Versions: 3.4, 3.5, 4.0
> Reporter: Simon Willnauer
> Fix For: 3.5, 4.0
>
>
> Current impl. for append on CharsRef is broken - it overrides the actual content rather than append. its used in many places especially in solr so we might have some broken
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-3548) CharsRef#append broken on trunk &
3.x
Posted by "Simon Willnauer (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer resolved LUCENE-3548.
-------------------------------------
Resolution: Fixed
fixed in trunk & backported to 3.x
> CharsRef#append broken on trunk & 3.x
> -------------------------------------
>
> Key: LUCENE-3548
> URL: https://issues.apache.org/jira/browse/LUCENE-3548
> Project: Lucene - Java
> Issue Type: Bug
> Components: core/other
> Affects Versions: 3.4, 3.5, 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Fix For: 3.5, 4.0
>
> Attachments: LUCENE-3548.patch
>
>
> Current impl. for append on CharsRef is broken - it overrides the actual content rather than append. its used in many places especially in solr so we might have some broken
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3548) CharsRef#append broken on trunk &
3.x
Posted by "Simon Willnauer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141188#comment-13141188 ]
Simon Willnauer commented on LUCENE-3548:
-----------------------------------------
bq. In my opinion the best thing we could do would be to have consistent Bytes/Chars/Ints/LongsRef apis
where all the methods have the same semantics!
+1 - I think we should fix the append one in 3.x since we released it and its totally broken (who did this again - oh me my fault!)
> CharsRef#append broken on trunk & 3.x
> -------------------------------------
>
> Key: LUCENE-3548
> URL: https://issues.apache.org/jira/browse/LUCENE-3548
> Project: Lucene - Java
> Issue Type: Bug
> Components: core/other
> Affects Versions: 3.4, 3.5, 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Fix For: 3.5, 4.0
>
> Attachments: LUCENE-3548.patch
>
>
> Current impl. for append on CharsRef is broken - it overrides the actual content rather than append. its used in many places especially in solr so we might have some broken
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3548) CharsRef#append broken on trunk &
3.x
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141189#comment-13141189 ]
Robert Muir commented on LUCENE-3548:
-------------------------------------
+1 to fixing things one piece at a time... no reason we have to fix it all at once
> CharsRef#append broken on trunk & 3.x
> -------------------------------------
>
> Key: LUCENE-3548
> URL: https://issues.apache.org/jira/browse/LUCENE-3548
> Project: Lucene - Java
> Issue Type: Bug
> Components: core/other
> Affects Versions: 3.4, 3.5, 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Fix For: 3.5, 4.0
>
> Attachments: LUCENE-3548.patch
>
>
> Current impl. for append on CharsRef is broken - it overrides the actual content rather than append. its used in many places especially in solr so we might have some broken
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org