You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "linghengqian (via GitHub)" <gi...@apache.org> on 2024/09/27 11:23:03 UTC

[PR] Bump the minimum Seata Client version for Seata integration to 2.1.0 to serve nativeTest under GraalVM Native Image [shardingsphere]

linghengqian opened a new pull request, #33030:
URL: https://github.com/apache/shardingsphere/pull/33030

   For #29052.
   
   Changes proposed in this pull request:
     - Bump the minimum Seata Client version for Seata integration to 2.1.0 to serve nativeTest under GraalVM Native Image
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [x] I have self-reviewed the commit code.
   - [x] I have (or in comment I request) added corresponding labels for the pull request.
   - [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [x] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump the minimum Seata Client version for Seata integration to 2.1.0 to serve nativeTest under GraalVM Native Image [shardingsphere]

Posted by "linghengqian (via GitHub)" <gi...@apache.org>.
linghengqian commented on code in PR #33030:
URL: https://github.com/apache/shardingsphere/pull/33030#discussion_r1779366772


##########
infra/reachability-metadata/src/main/resources/META-INF/native-image/com.github.ben-manes.caffeine/caffeine/2.9.3/reflect-config.json:
##########
@@ -99,19 +99,16 @@
   "name":"com.github.benmanes.caffeine.cache.StripedBuffer",
   "fields":[{"name":"tableBusy"}]
 },
+{
+  "condition":{"typeReachable":"com.github.benmanes.caffeine.cache.NodeFactory"},
+  "name":"com.github.benmanes.caffeine.cache.PDWMS",
+  "methods":[{"name":"<init>","parameterTypes":[] }]
+},
 {
   "condition":{"typeReachable":"com.github.benmanes.caffeine.cache.StripedBuffer"},
   "name":"java.lang.Thread",
   "fields":[{"name":"threadLocalRandomProbe"}]
 },
-{
-  "condition":{"typeReachable":"com.github.benmanes.caffeine.cache.LocalLoadingCache"},
-  "name":"org.apache.shardingsphere.infra.parser.cache.SQLStatementCacheLoader"
-},
-{
-  "condition":{"typeReachable":"com.github.benmanes.caffeine.cache.LocalLoadingCache"},
-  "name":"org.apache.shardingsphere.sql.parser.core.database.cache.ParseTreeCacheLoader"
-},

Review Comment:
   - I noticed that this was introduced via #32633. But the question is, these two JSONs are actually already located in `infra/reachability-metadata/src/main/resources/META-INF/native-image/org.apache.shardingsphere/generated-reachability-metadata/reflect-config.json`, does this affect any unit tests?



##########
infra/reachability-metadata/src/main/resources/META-INF/native-image/com.github.ben-manes.caffeine/caffeine/2.9.3/reflect-config.json:
##########
@@ -99,19 +99,16 @@
   "name":"com.github.benmanes.caffeine.cache.StripedBuffer",
   "fields":[{"name":"tableBusy"}]
 },
+{
+  "condition":{"typeReachable":"com.github.benmanes.caffeine.cache.NodeFactory"},
+  "name":"com.github.benmanes.caffeine.cache.PDWMS",
+  "methods":[{"name":"<init>","parameterTypes":[] }]
+},
 {
   "condition":{"typeReachable":"com.github.benmanes.caffeine.cache.StripedBuffer"},
   "name":"java.lang.Thread",
   "fields":[{"name":"threadLocalRandomProbe"}]
 },
-{
-  "condition":{"typeReachable":"com.github.benmanes.caffeine.cache.LocalLoadingCache"},
-  "name":"org.apache.shardingsphere.infra.parser.cache.SQLStatementCacheLoader"
-},
-{
-  "condition":{"typeReachable":"com.github.benmanes.caffeine.cache.LocalLoadingCache"},
-  "name":"org.apache.shardingsphere.sql.parser.core.database.cache.ParseTreeCacheLoader"
-},

Review Comment:
   - I noticed that this was introduced via #32633. But the question is, these two JSONs are actually already located in `infra/reachability-metadata/src/main/resources/META-INF/native-image/org.apache.shardingsphere/generated-reachability-metadata/reflect-config.json`, does this affect any unit tests?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump the minimum Seata Client version for Seata integration to 2.1.0 to serve nativeTest under GraalVM Native Image [shardingsphere]

Posted by "linghengqian (via GitHub)" <gi...@apache.org>.
linghengqian commented on code in PR #33030:
URL: https://github.com/apache/shardingsphere/pull/33030#discussion_r1779366928


##########
infra/reachability-metadata/src/main/resources/META-INF/native-image/com.github.ben-manes.caffeine/caffeine/2.9.3/reflect-config.json:
##########
@@ -99,19 +99,16 @@
   "name":"com.github.benmanes.caffeine.cache.StripedBuffer",
   "fields":[{"name":"tableBusy"}]
 },
+{
+  "condition":{"typeReachable":"com.github.benmanes.caffeine.cache.NodeFactory"},
+  "name":"com.github.benmanes.caffeine.cache.PDWMS",
+  "methods":[{"name":"<init>","parameterTypes":[] }]
+},
 {
   "condition":{"typeReachable":"com.github.benmanes.caffeine.cache.StripedBuffer"},
   "name":"java.lang.Thread",
   "fields":[{"name":"threadLocalRandomProbe"}]
 },
-{
-  "condition":{"typeReachable":"com.github.benmanes.caffeine.cache.LocalLoadingCache"},
-  "name":"org.apache.shardingsphere.infra.parser.cache.SQLStatementCacheLoader"
-},
-{
-  "condition":{"typeReachable":"com.github.benmanes.caffeine.cache.LocalLoadingCache"},
-  "name":"org.apache.shardingsphere.sql.parser.core.database.cache.ParseTreeCacheLoader"
-},

Review Comment:
   - @strongduanmu I noticed that this was introduced via #32633 . But the question is, these two JSONs are actually already located in `infra/reachability-metadata/src/main/resources/META-INF/native-image/org.apache.shardingsphere/generated-reachability-metadata/reflect-config.json`, does this affect any unit tests?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org