You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/08/23 00:22:11 UTC
[jira] [Commented] (CB-7372) Prepare for FirefoxOS on Windows
generates incorrect path
[ https://issues.apache.org/jira/browse/CB-7372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107605#comment-14107605 ]
ASF GitHub Bot commented on CB-7372:
------------------------------------
GitHub user Menardi opened a pull request:
https://github.com/apache/cordova-lib/pull/77
CB-7372 Remove use of path.join for manifest.launch_path
I was having issues on Windows when creating a new FirefoxOS project. A brand new project, when added to the Firefox App Manager, gave an error: "Launch path has to be an absolute path starting with '/': '\index.html'". The issue is the use of path.join to generate manifest.launch_path. On Windows, this uses backslashes, which caused the issue. I have opted to simply use concatenation instead.
I have also fixed an issue where "cordova prepare firefoxos" would fail if there was no <content> tag in the config.xml. If it is not present, we default to index.html.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Menardi/cordova-lib patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/77.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #77
----
commit d79f0c16e89a77e682b750e10c195e45bf1430c2
Author: Menardi <he...@gearoid.me>
Date: 2014-08-22T21:35:13Z
Remove use of path.join for manifest.launch_path
I was having issues on Windows when creating a new FirefoxOS project. A brand new project, when added to the Firefox App Manager, gave an error: "Launch path has to be an absolute path starting with '/': '\index.html'". The issue is the use of path.join to generate manifest.launch_path. On Windows, this uses backslashes, which caused the issue. I have opted to simply use concatenation instead.
I have also fixed an issue where "cordova prepare firefoxos" would fail if there was no <content> tag in the config.xml. If it is not present, we default to index.html.
----
> Prepare for FirefoxOS on Windows generates incorrect path
> ---------------------------------------------------------
>
> Key: CB-7372
> URL: https://issues.apache.org/jira/browse/CB-7372
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, FirefoxOS
> Affects Versions: 3.5.0
> Environment: Windows 8 64-bit
> Reporter: Gearóid Moroney
> Priority: Critical
>
> On Windows, the manifest.webapp file for Firefox OS has an invalid path. The file must be edited manually to get the app to work.
> To reproduce:
> - Install Cordova 3.5.0
> - Create a new project: cordova create test
> - In the test folder, add FxOS: cordova platform add firefoxos
> - Package the app. For FxOS all that needs to be done is prepare: cordova prepare firefoxos
> - In Firefox (at least version 26), go to about:app-manager
> - Click Apps on the left, and then "Add Packaged App" on the bottom. Select test/platforms/firefoxos/www
> - On the right-hand side, notice the error: "Launch path has to be an absolute path starting with '/': '\index.html'"
> I have a fix ready for this and will submit a pull request on GitHub.
--
This message was sent by Atlassian JIRA
(v6.2#6252)