[GitHub] [hadoop] haiyang1987 commented on a diff in pull request #4903: HDFS-16774.Improve async delete replica on datanode

[GitBox <gi...@apache.org>]

haiyang1987 commented on code in PR #4903:
URL: https://github.com/apache/hadoop/pull/4903#discussion_r977073373


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java:
##########
@@ -2310,10 +2310,10 @@ private void invalidate(String bpid, Block[] invalidBlks, boolean async)
       throws IOException {
     final List<String> errors = new ArrayList<String>();
     for (int i = 0; i < invalidBlks.length; i++) {
-      final ReplicaInfo removing;
+      final ReplicaInfo info;

Review Comment:
   > Is it possible to move segment L2313~L2349 to async also? Because it includes some IO request here. # this is not blocker issue.
   
   At present, it is no changed to asynchronous mainly because 
   1.List<String> errors are defined in L2311, which will record the replicas that failed to delete and return IOException synchronously according to the errors list information
   2.FsDatasetAsyncDiskService#deleteAsync and init ReplicaFileDeleteTask require ReplicaInfo and FsVolumeImpl etc info
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org