You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/22 02:32:47 UTC

[GitHub] [pulsar-client-go] quintans opened a new pull request #329: [ISSUE-328][reader] gets last message when LatestMessageID and inclusive

quintans opened a new pull request #329:
URL: https://github.com/apache/pulsar-client-go/pull/329


   Signed-off-by: Paulo Pereira <pa...@karhoo.com>
   
   Fixes #328 
   
   ### Motivation
   
   I have a service that when it restarts, it needs to know what was the last message successfully sent to pulsar.
   A reader seems the logical place, since we can specify `StartMessageID` as `LatestMessageID()` and `StartMessageIDInclusive`
   
   ### Modifications
   
   When the reader is created, verify if it startMessageIDInclusive true and startMessageID == lastestMessageID() and then get the last message id and seek to that message id.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   This change added tests and can be verified as follows:
   - integration tests to verify that a reader has the last message, when specifying `StartMessageIDInclusive` and `LastestMessageID`
   
   ### Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: no
     - The schema: no
     - The default values of configurations: no
     - The wire protocol: no
   
   ### Documentation
   
     - Does this pull request introduce a new feature? no
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] wolfstudy merged pull request #329: [ISSUE-328] gets last message when LatestMessageID and inclusive

Posted by GitBox <gi...@apache.org>.
wolfstudy merged pull request #329:
URL: https://github.com/apache/pulsar-client-go/pull/329


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org