You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by "Roger Whitcomb (JIRA)" <ji...@apache.org> on 2018/08/13 02:02:00 UTC
[jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds
and make changes to bring code into better compliance
[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577762#comment-16577762 ]
Roger Whitcomb commented on PIVOT-1032:
---------------------------------------
Finished the rest of the "Whitespace" errors and some other style errors in the smaller files:
Sending core/src/org/apache/pivot/beans/BXMLSerializer.java
Sending core/src/org/apache/pivot/collections/Dictionary.java
Sending core/src/org/apache/pivot/text/CharSpan.java
Sending core/src/org/apache/pivot/util/CharUtils.java
Sending core/src/org/apache/pivot/util/ImageUtils.java
Sending core/src/org/apache/pivot/util/Resources.java
Sending core/src/org/apache/pivot/util/Utils.java
Sending core/src/org/apache/pivot/util/Version.java
Sending core/test/org/apache/pivot/json/test/JSONSerializerTest.java
Sending core/test/org/apache/pivot/serialization/test/BinarySerializerTest.java
Sending demos/src/org/apache/pivot/demos/rest/RESTDemoTest.java
Sending eclipse/src/org/apache/pivot/eclipse/PivotApplicationLaunchShortcut.java
Sending eclipse/src/org/apache/pivot/eclipse/PivotScriptApplicationLaunchShortcut.java
Transmitting file data .............done
Committing transaction...
Committed revision 1837911.
Sending tests/src/org/apache/pivot/tests/CheckedListViewTest.java
Sending tests/src/org/apache/pivot/tests/DataBindingTest.java
Sending tests/src/org/apache/pivot/tests/LabelAntialiasTest.java
Sending tests/src/org/apache/pivot/tests/NamespaceTest.java
Sending tests/src/org/apache/pivot/tests/issues/Pivot738.java
Sending tests/src/org/apache/pivot/tests/issues/Pivot765.java
Sending tests/src/org/apache/pivot/tests/issues/Pivot800.java
Sending tests/src/org/apache/pivot/tests/issues/Pivot811.java
Sending tests/src/org/apache/pivot/tests/issues/pivot859/Pivot859.java
Sending tests/src/org/apache/pivot/tests/issues/pivot948/Pivot948.java
Sending tests/src/org/apache/pivot/tests/issues/pivot964/Pivot964Pivot.java
Sending tests/src/org/apache/pivot/tests/issues/pivot965/Pivot965Main.java
Sending tutorials/src/org/apache/pivot/tutorials/explorer/tools/EventLogger.java
Sending tutorials/src/org/apache/pivot/tutorials/layout/Forms.java
Transmitting file data ..............done
Committing transaction...
Committed revision 1837912.
Sending wtk/src/org/apache/pivot/wtk/Button.java
Sending wtk/src/org/apache/pivot/wtk/Component.java
Sending wtk/src/org/apache/pivot/wtk/Dimensions.java
Sending wtk/src/org/apache/pivot/wtk/HyperlinkButton.java
Sending wtk/src/org/apache/pivot/wtk/Label.java
Sending wtk/src/org/apache/pivot/wtk/Limits.java
Sending wtk/src/org/apache/pivot/wtk/Point.java
Sending wtk/src/org/apache/pivot/wtk/ScriptApplication.java
Sending wtk/src/org/apache/pivot/wtk/ScrollBar.java
Sending wtk/src/org/apache/pivot/wtk/Span.java
Sending wtk/src/org/apache/pivot/wtk/TextPane.java
Sending wtk/src/org/apache/pivot/wtk/content/ListViewIndexBindMapping.java
Sending wtk/src/org/apache/pivot/wtk/content/SpinnerIndexBindMapping.java
Sending wtk/src/org/apache/pivot/wtk/skin/TextPaneSkin.java
Sending wtk/src/org/apache/pivot/wtk/skin/TextPaneSkinNodeView.java
Sending wtk/src/org/apache/pivot/wtk/skin/TextPaneSkinNumberedListView.java
Sending wtk/src/org/apache/pivot/wtk/text/ComponentNode.java
Sending wtk/src/org/apache/pivot/wtk/text/Element.java
Sending wtk/src/org/apache/pivot/wtk/text/Paragraph.java
Transmitting file data ...................done
Committing transaction...
Committed revision 1837913.
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraActivityIndicatorSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraAlertSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraCalendarButtonSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraCalendarSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraColorChooserButtonSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraExpanderSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraGaugeSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListButtonSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuBarSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuButtonSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuItemSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraPanoramaSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraPromptSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraPushButtonSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraRadioButtonSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraRollupSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSliderSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSpinnerSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSplitPaneSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraVFSBrowserSkin.java
Transmitting file data ....................done
Committing transaction...
Committed revision 1837914.
> Implement "checkstyle" for builds and make changes to bring code into better compliance
> ---------------------------------------------------------------------------------------
>
> Key: PIVOT-1032
> URL: https://issues.apache.org/jira/browse/PIVOT-1032
> Project: Pivot
> Issue Type: Improvement
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Attachments: 1032.diffs.txt
>
>
> I thought it would be interesting, in addition to the "trim-whitespace" task already implemented, to do some sort of "checkstyle" processing to evaluate all the code to see where there might be changes to make the code more robust and a better example of "canonical" Java style.
> I hesitate to expect that we could address everything (or indeed whether we *should*), but there might be things that would make the code better and easier to read and maintain, and wouldn't take much effort.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)