You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/09/03 00:02:12 UTC
[GitHub] [helix] zhangmeng916 opened a new pull request #1342: Clean up instance validation logic and test
zhangmeng916 opened a new pull request #1342:
URL: https://github.com/apache/helix/pull/1342
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
Fixed #1341
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
The cluster config null check and instance validation check are tangled together right now. We would like to make them clear and return proper error message to users. Also there are two tests in helix-core and helix-rest with exactly name about instance validation. We want to distinguish them to avoid confusion.
This PR put cluster config null check into valid instance config check, together with persist intermediate state check. If either of them is false, the instance validation check will fail with a "false" return, instead of throwing an exception.
It also renamed one of the test in `TestInstanceValidationUtil` so that helix-core and helix-rest don't have duplicated test names.
### Tests
- [ ] The following is the result of the "mvn test" command on the appropriate module:
(Before CI test pass, please copy & paste the result of "mvn test")
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm merged pull request #1342: Clean up instance validation logic and test
Posted by GitBox <gi...@apache.org>.
pkuwm merged pull request #1342:
URL: https://github.com/apache/helix/pull/1342
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] zhangmeng916 commented on pull request #1342: Clean up instance validation logic and test
Posted by GitBox <gi...@apache.org>.
zhangmeng916 commented on pull request #1342:
URL: https://github.com/apache/helix/pull/1342#issuecomment-686220808
This PR is ready to be merged, approved by @pkuwm
Final commit message:
Clean up instance validation logic and test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm commented on a change in pull request #1342: Clean up instance validation logic and test
Posted by GitBox <gi...@apache.org>.
pkuwm commented on a change in pull request #1342:
URL: https://github.com/apache/helix/pull/1342#discussion_r482622803
##########
File path: helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java
##########
@@ -159,12 +159,14 @@ public static boolean hasValidConfig(HelixDataAccessor dataAccessor, String clus
PropertyKey.Builder keyBuilder = dataAccessor.keyBuilder();
ClusterConfig clusterConfig = dataAccessor.getProperty(keyBuilder.clusterConfig());
if (clusterConfig == null) {
- throw new HelixException("Cluster config is missing in cluster " + clusterId);
+ _logger.error("Cluster config is missing in cluster " + clusterId);
+ return false;
}
if (!clusterConfig.isPersistIntermediateAssignment()) {
- throw new HelixException(String.format(
+ _logger.error(String.format(
Review comment:
Remove `String.format`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org