[jira] [Commented] (YARN-10006) IOException used in place of YARNException in CapaitySheduler

["Adam Antal (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-10006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988708#comment-16988708 ] 

Adam Antal commented on YARN-10006:
-----------------------------------

Uploaded patch v1.

{{CapacitySchedulerQueueManager#parseQueue}} has multiple sources where IOException can be thrown (e.g. in the constructor of {{PlanQueue}}, {{ReservationQueue}}, {{ManagedParentQueue}}, {{LeafQueue}}). Also in {{CapacityScheduler#initializeQueues}} there are other calls that throw IOException (like {{#updatePlacementRules}}), so I think it's better to catch any arbitrary type of Exceptions in {{initializeQueues}}, and emit a {{YarnException}} there.

Also I think it's logically correct that in {{CapacityScheduler#initScheduler}} we can throw IOException too (from {{CSConfigurationProvider#init}} and {{#loadConfiguration}}), because it refers to failed IO operation.

> IOException used in place of YARNException in CapaitySheduler
> -------------------------------------------------------------
>
>                 Key: YARN-10006
>                 URL: https://issues.apache.org/jira/browse/YARN-10006
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacity scheduler
>    Affects Versions: 3.3.0
>            Reporter: Prabhu Joseph
>            Assignee: Adam Antal
>            Priority: Minor
>         Attachments: YARN-10006.001.patch
>
>
> IOException used in place of YARNException in CapacityScheduler. As per YARNException Doc,
> {code:java}
> /**
>  * YarnException indicates exceptions from yarn servers. On the other hand,
>  * IOExceptions indicates exceptions from RPC layer.
>  */
> {code}
> Below methods throws IOException but it is suppose to throw YarnException.
> CapacitySchedulerQueueManager#parseQueue <- initializeQueues <- CapacityScheduler#initializeQueues <- initScheduler <- serviceInit



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org