DO NOT REPLY [Bug 16057] New: - module fails to init client_rmm and applies too many locks.

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16057>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16057

module fails to init client_rmm and applies too many locks.

           Summary: module fails to init client_rmm and applies too many
                    locks.
           Product: Apache httpd-2.0
           Version: 2.0.43
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Major
          Priority: Other
         Component: mod_auth_digest
        AssignedTo: bugs@httpd.apache.org
        ReportedBy: achowe@snert.com


While porting mod_watch to Apache 2.0, I looked at mod_auth_digest as an example
of a module using shared memory and mutexes.  While looking at it I found what I
would consider to be some serious problems with the code:

a) No where in the module is client_rmm initialised before being used.

b) Line 1103 has the following:

    apr_global_mutex_lock(opaque_lock);
    op = (*opaque_cntr)++;
    apr_global_mutex_lock(opaque_lock);

I think the second apr_global_mutex_lock() should be apr_global_mutex_unlock().

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org