You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-dev@portals.apache.org by "David H. DeWolf" <dd...@apache.org> on 2005/07/14 05:06:02 UTC

Re: [jira] Commented: (PLUTO-38) user profile attribute support

ok, I'll wait. . .let me know when you think the patch is stable.

Elliot Metsger (JIRA) wrote:
>     [ http://issues.apache.org/jira/browse/PLUTO-38?page=comments#action_12313485 ] 
> 
> Elliot Metsger commented on PLUTO-38:
> -------------------------------------
> 
> am re-thinking modifing the portletapplicationdefintion interface to expose userattributes. ..
> 
> 
>>user profile attribute support
>>------------------------------
>>
>>         Key: PLUTO-38
>>         URL: http://issues.apache.org/jira/browse/PLUTO-38
>>     Project: Pluto
>>        Type: New Feature
>>  Components: portal driver
>>    Versions: 1.1.0-ALPHA
>> Environment: Operating System: All
>>Platform: All
>>    Reporter: Nick Lothian
>>    Priority: Minor
>>     Fix For: 1.1.0-ALPHA
>> Attachments: PLUTO-38_userattribute.patch
>>
>>user profile attribute support
>>This was previously on the TODO list on bug 25282
> 
> 


Re: [jira] Commented: (PLUTO-38) user profile attribute support

Posted by Stefan Hepper <st...@apache.org>.
Elliot Metsger wrote:

> David H. DeWolf wrote:
> > ok, I'll wait. . .let me know when you think the patch is stable.
> >
> > Elliot Metsger (JIRA) wrote:
> >
> >>     [
> >> 
> http://issues.apache.org/jira/browse/PLUTO-38?page=comments#action_12313485 
>
> >> ]
> >> Elliot Metsger commented on PLUTO-38:
> >> -------------------------------------
> >>
> >> am re-thinking modifing the portletapplicationdefintion interface to
> >> expose userattributes. ..
>
> Well,
>
> This is a question for the list I guess.
>
> Is PortletApplicationDefinition meant to model the elements of 
> portlet.xml?  Currently the interface defines a way to get at:
> + the list of portlets (PortletDefintionList getPortletDefinitionList())
> + the version of the portlet application (String getVersion())
> + the identifier of the portlet application. (ObjectID getId())
> + the webapplication deployment descriptor. (WebApplicationDefinition 
> getWebApplicationDefinition())
>
> Things like user-attributes, custom-portlet-mode, custom-window-state, 
> and security-constraint (children of <portlet-app> in portlet.xml) are 
> not accessable from PortletApplicationDefinition.  One reason I'm 
> questioning the modification of the interface is that user attributes 
> is there as a private ArrayList in PortalApplicationDefinitionImpl and 
> someone either consiouscly made a decision not to expose it in the 
> interface or inadvertently forgot.  So if someone (smarter than ME!) 
> made a decision not to expose it then maybe it shouldn't be exposed.
>
> Elliot
>

I think we made that decission back then because the support of user 
attributes was optional in the spec so we just let it out (same reason 
for the other optional parts: custom portlet modes / window states). I 
think we should add it to the portlet app definition.

Thanks

Stefan

>>>
>>>
>>>> user profile attribute support
>>>> ------------------------------
>>>>
>>>>         Key: PLUTO-38
>>>>         URL: http://issues.apache.org/jira/browse/PLUTO-38
>>>>     Project: Pluto
>>>>        Type: New Feature
>>>>  Components: portal driver
>>>>    Versions: 1.1.0-ALPHA
>>>> Environment: Operating System: All
>>>> Platform: All
>>>>    Reporter: Nick Lothian
>>>>    Priority: Minor
>>>>     Fix For: 1.1.0-ALPHA
>>>> Attachments: PLUTO-38_userattribute.patch
>>>>
>>>> user profile attribute support
>>>> This was previously on the TODO list on bug 25282
>>>
>>>
>>>
>>>
>
>


Re: [jira] Commented: (PLUTO-38) user profile attribute support

Posted by Elliot Metsger <em...@jhu.edu>.
David H. DeWolf wrote:
 > ok, I'll wait. . .let me know when you think the patch is stable.
 >
 > Elliot Metsger (JIRA) wrote:
 >
 >>     [
 >> 
http://issues.apache.org/jira/browse/PLUTO-38?page=comments#action_12313485
 >> ]
 >> Elliot Metsger commented on PLUTO-38:
 >> -------------------------------------
 >>
 >> am re-thinking modifing the portletapplicationdefintion interface to
 >> expose userattributes. ..

Well,

This is a question for the list I guess.

Is PortletApplicationDefinition meant to model the elements of 
portlet.xml?  Currently the interface defines a way to get at:
+ the list of portlets (PortletDefintionList getPortletDefinitionList())
+ the version of the portlet application (String getVersion())
+ the identifier of the portlet application. (ObjectID getId())
+ the webapplication deployment descriptor. (WebApplicationDefinition 
getWebApplicationDefinition())

Things like user-attributes, custom-portlet-mode, custom-window-state, 
and security-constraint (children of <portlet-app> in portlet.xml) are 
not accessable from PortletApplicationDefinition.  One reason I'm 
questioning the modification of the interface is that user attributes is 
there as a private ArrayList in PortalApplicationDefinitionImpl and 
someone either consiouscly made a decision not to expose it in the 
interface or inadvertently forgot.  So if someone (smarter than ME!) 
made a decision not to expose it then maybe it shouldn't be exposed.

Elliot

>>
>>
>>> user profile attribute support
>>> ------------------------------
>>>
>>>         Key: PLUTO-38
>>>         URL: http://issues.apache.org/jira/browse/PLUTO-38
>>>     Project: Pluto
>>>        Type: New Feature
>>>  Components: portal driver
>>>    Versions: 1.1.0-ALPHA
>>> Environment: Operating System: All
>>> Platform: All
>>>    Reporter: Nick Lothian
>>>    Priority: Minor
>>>     Fix For: 1.1.0-ALPHA
>>> Attachments: PLUTO-38_userattribute.patch
>>>
>>> user profile attribute support
>>> This was previously on the TODO list on bug 25282
>>
>>
>>