You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/02 13:30:22 UTC

[GitHub] [airflow] YangMuye commented on a change in pull request #14024: Allow list item to be rendered as taget renderer instead of showing JSON

YangMuye commented on a change in pull request #14024:
URL: https://github.com/apache/airflow/pull/14024#discussion_r568601212



##########
File path: airflow/www/views.py
##########
@@ -898,7 +898,7 @@ def rendered_templates(self):
             content = getattr(task, template_field)
             renderer = task.template_fields_renderers.get(template_field, template_field)
             if renderer in renderers:
-                if isinstance(content, (dict, list)):
+                if isinstance(content, dict):

Review comment:
       As a work-around, we can handle it here. But I actually believe the logic should be handled by the renderer itself.
   Just make JSON renderer the fallback renderer.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org