You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by xi...@apache.org on 2022/02/28 17:08:23 UTC

[incubator-nuttx] branch master updated (0961f12 -> 36909f5)

This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.


    from 0961f12  arm/phy62xx: remove unused private header
     new b0e6a6e  input/djoystick: Remove the unused config field from djoy_lowerhalf_s
     new aac9c4b  input/ajoystck: Remove ajoy_enable from ajoy_sample
     new 207249a  input/djoystck: Remove djoy_enable from djoy_sample
     new 478b292  input/buttons: Remove btn_enable from btn_sample
     new f4b1b12  input/ajoystick: Remove the unused au_enabled from ajoy_upperhalf_s
     new 70d9034  input/djoystick: Remove the unused du_enabled from djoy_upperhalf_s
     new 36909f5  input/buttons: Remove the unused bu_enabled from btn_upperhalf_s

The 7 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 drivers/input/ajoystick.c       | 5 -----
 drivers/input/button_upper.c    | 5 -----
 drivers/input/djoystick.c       | 5 -----
 include/nuttx/input/djoystick.h | 6 ------
 4 files changed, 21 deletions(-)

[incubator-nuttx] 07/07: input/buttons: Remove the unused bu_enabled from btn_upperhalf_s

Posted by xi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git

commit 36909f5f6c80248bedacdaeba7439247a2d4827a
Author: Xiang Xiao <xi...@xiaomi.com>
AuthorDate: Sun Feb 27 15:55:01 2022 +0800

    input/buttons: Remove the unused bu_enabled from btn_upperhalf_s
    
    Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
---
 drivers/input/button_upper.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/input/button_upper.c b/drivers/input/button_upper.c
index b2d9446..ecb669a 100644
--- a/drivers/input/button_upper.c
+++ b/drivers/input/button_upper.c
@@ -59,7 +59,6 @@ struct btn_upperhalf_s
 
   FAR const struct btn_lowerhalf_s *bu_lower;
 
-  btn_buttonset_t bu_enabled; /* Set of currently enabled button interrupts */
   btn_buttonset_t bu_sample;  /* Last sampled button states */
   sem_t bu_exclsem;           /* Supports exclusive access to the device */
 

[incubator-nuttx] 05/07: input/ajoystick: Remove the unused au_enabled from ajoy_upperhalf_s

Posted by xi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git

commit f4b1b1262f203af027a15fbaf607a431dc63bde9
Author: Xiang Xiao <xi...@xiaomi.com>
AuthorDate: Sun Feb 27 15:56:32 2022 +0800

    input/ajoystick: Remove the unused au_enabled from ajoy_upperhalf_s
    
    Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
---
 drivers/input/ajoystick.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/input/ajoystick.c b/drivers/input/ajoystick.c
index 443aeb7..312f8ea 100644
--- a/drivers/input/ajoystick.c
+++ b/drivers/input/ajoystick.c
@@ -63,7 +63,6 @@ struct ajoy_upperhalf_s
 
   FAR const struct ajoy_lowerhalf_s *au_lower;
 
-  ajoy_buttonset_t au_enabled; /* Set of currently enabled button interrupts */
   ajoy_buttonset_t au_sample;  /* Last sampled button states */
   sem_t au_exclsem;            /* Supports exclusive access to the device */
 

[incubator-nuttx] 03/07: input/djoystck: Remove djoy_enable from djoy_sample

Posted by xi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git

commit 207249afdcd3ec283804490fbaa8b6fc4a985a15
Author: Xiang Xiao <xi...@xiaomi.com>
AuthorDate: Sun Feb 27 03:11:22 2022 +0800

    input/djoystck: Remove djoy_enable from djoy_sample
    
    since djoy_sample doesn't change the status
    
    Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
---
 drivers/input/djoystick.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/input/djoystick.c b/drivers/input/djoystick.c
index e7f9584..1ce8baf 100644
--- a/drivers/input/djoystick.c
+++ b/drivers/input/djoystick.c
@@ -331,10 +331,6 @@ static void djoy_sample(FAR struct djoy_upperhalf_s *priv)
         }
     }
 
-  /* Enable/disable interrupt handling */
-
-  djoy_enable(priv);
-
   priv->du_sample = sample;
   leave_critical_section(flags);
 }

[incubator-nuttx] 06/07: input/djoystick: Remove the unused du_enabled from djoy_upperhalf_s

Posted by xi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git

commit 70d90340c7bda300a46c8c52697617f63d5439ed
Author: Xiang Xiao <xi...@xiaomi.com>
AuthorDate: Sun Feb 27 15:57:05 2022 +0800

    input/djoystick: Remove the unused du_enabled from djoy_upperhalf_s
    
    Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
---
 drivers/input/djoystick.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/input/djoystick.c b/drivers/input/djoystick.c
index 1ce8baf..d1643c8 100644
--- a/drivers/input/djoystick.c
+++ b/drivers/input/djoystick.c
@@ -63,7 +63,6 @@ struct djoy_upperhalf_s
 
   FAR const struct djoy_lowerhalf_s *du_lower;
 
-  djoy_buttonset_t du_enabled; /* Set of currently enabled button interrupts */
   djoy_buttonset_t du_sample;  /* Last sampled button states */
   sem_t du_exclsem;            /* Supports exclusive access to the device */
 

[incubator-nuttx] 02/07: input/ajoystck: Remove ajoy_enable from ajoy_sample

Posted by xi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git

commit aac9c4b78a79b5a914495a3199be79e51f0e1c3f
Author: Xiang Xiao <xi...@xiaomi.com>
AuthorDate: Wed Jan 12 00:33:29 2022 +0800

    input/ajoystck: Remove ajoy_enable from ajoy_sample
    
    since ajoy_sample doesn't change the status
    
    Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
---
 drivers/input/ajoystick.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/input/ajoystick.c b/drivers/input/ajoystick.c
index 64ed1c5..443aeb7 100644
--- a/drivers/input/ajoystick.c
+++ b/drivers/input/ajoystick.c
@@ -331,10 +331,6 @@ static void ajoy_sample(FAR struct ajoy_upperhalf_s *priv)
         }
     }
 
-  /* Enable/disable interrupt handling */
-
-  ajoy_enable(priv);
-
   priv->au_sample = sample;
   leave_critical_section(flags);
 }

[incubator-nuttx] 01/07: input/djoystick: Remove the unused config field from djoy_lowerhalf_s

Posted by xi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git

commit b0e6a6e0811b49d73dc676cc4849a017f835e0d9
Author: Xiang Xiao <xi...@xiaomi.com>
AuthorDate: Sun Feb 27 03:07:59 2022 +0800

    input/djoystick: Remove the unused config field from djoy_lowerhalf_s
    
    the private data should be done like this:
    struct xxx_lowerhalf_s
    {
      struct djoy_lowerhalf_s lower;
    
      /* Add more private data here */
    };
    
    Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
---
 include/nuttx/input/djoystick.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/include/nuttx/input/djoystick.h b/include/nuttx/input/djoystick.h
index fff707f..d35f550 100644
--- a/include/nuttx/input/djoystick.h
+++ b/include/nuttx/input/djoystick.h
@@ -220,12 +220,6 @@ struct djoy_lowerhalf_s
   CODE void (*dl_enable)(FAR const struct djoy_lowerhalf_s *lower,
                          djoy_buttonset_t press, djoy_buttonset_t release,
                          djoy_interrupt_t handler, FAR void *arg);
-
-  /* Allow for storing implementation specific data to support cases where
-   * their may be more than one joystick
-   */
-
-  FAR void *config;
 };
 
 /****************************************************************************

[incubator-nuttx] 04/07: input/buttons: Remove btn_enable from btn_sample

Posted by xi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git

commit 478b292a87e3851810e4c350b0bda94ce645e895
Author: Xiang Xiao <xi...@xiaomi.com>
AuthorDate: Sun Feb 27 16:01:40 2022 +0800

    input/buttons: Remove btn_enable from btn_sample
    
    since btn_sample doesn't change the status
    
    Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
---
 drivers/input/button_upper.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/input/button_upper.c b/drivers/input/button_upper.c
index 2493724..b2d9446 100644
--- a/drivers/input/button_upper.c
+++ b/drivers/input/button_upper.c
@@ -317,10 +317,6 @@ static void btn_sample(FAR struct btn_upperhalf_s *priv)
         }
     }
 
-  /* Enable/disable interrupt handling */
-
-  btn_enable(priv);
-
   priv->bu_sample = sample;
   leave_critical_section(flags);
 }