You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/31 08:27:45 UTC

[GitHub] [incubator-shardingsphere] yu199195 opened a new pull request #5019: ues strategy pattern modify refresh ShardingMetaData.

yu199195 opened a new pull request #5019:  ues strategy pattern modify refresh ShardingMetaData.
URL: https://github.com/apache/incubator-shardingsphere/pull/5019
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] yu199195 commented on a change in pull request #5019: ues strategy pattern modify refresh ShardingMetaData.

Posted by GitBox <gi...@apache.org>.
yu199195 commented on a change in pull request #5019:  ues strategy pattern modify refresh ShardingMetaData.
URL: https://github.com/apache/incubator-shardingsphere/pull/5019#discussion_r400825040
 
 

 ##########
 File path: sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/refreh/SQLStatementMetaDataRefreshFactory.java
 ##########
 @@ -0,0 +1,39 @@
+package org.apache.shardingsphere.shardingjdbc.jdbc.refreh;
+
+import org.apache.shardingsphere.sql.parser.binder.statement.SQLStatementContext;
+import org.apache.shardingsphere.sql.parser.binder.statement.ddl.AlterTableStatementContext;
+import org.apache.shardingsphere.sql.parser.binder.statement.ddl.CreateIndexStatementContext;
+import org.apache.shardingsphere.sql.parser.binder.statement.ddl.CreateTableStatementContext;
+import org.apache.shardingsphere.sql.parser.binder.statement.ddl.DropIndexStatementContext;
+import org.apache.shardingsphere.sql.parser.binder.statement.ddl.DropTableStatementContext;
+import org.apache.shardingsphere.sql.parser.sql.statement.SQLStatement;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Optional;
+
+/**
+ * The type Sql statement meta data refresh factory.
+ */
+public final class SQLStatementMetaDataRefreshFactory {
+    
+    private static final Map<Class<?>, SQLStatementMetaDataRefresh<? extends SQLStatement>> REFRESH_MAP = new HashMap<>();
+    
+    static {
+        REFRESH_MAP.put(CreateTableStatementContext.class, new CreateTableStatementMetaDataRefresh());
+        REFRESH_MAP.put(AlterTableStatementContext.class, new AlterTableStatementMetaDataRefresh());
+        REFRESH_MAP.put(DropTableStatementContext.class, new DropTableStatementMetaDataRefresh());
+        REFRESH_MAP.put(CreateIndexStatementContext.class, new CreateIndexStatementMetaDataRefresh());
+        REFRESH_MAP.put(DropIndexStatementContext.class, new DropIndexStatementMetaDataRefresh());
+    }
+    
+    /**
+     * New instance sql statement meta data refresh.
 
 Review comment:
   fix.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #5019: ues strategy pattern modify refresh ShardingMetaData.

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #5019:  ues strategy pattern modify refresh ShardingMetaData.
URL: https://github.com/apache/incubator-shardingsphere/pull/5019#discussion_r400775491
 
 

 ##########
 File path: sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/refreh/DropTableStatementMetaDataRefresh.java
 ##########
 @@ -0,0 +1,20 @@
+package org.apache.shardingsphere.shardingjdbc.jdbc.refreh;
+
+import org.apache.shardingsphere.shardingjdbc.jdbc.core.context.ShardingRuntimeContext;
+import org.apache.shardingsphere.sql.parser.binder.statement.SQLStatementContext;
+import org.apache.shardingsphere.sql.parser.sql.segment.generic.table.SimpleTableSegment;
+import org.apache.shardingsphere.sql.parser.sql.statement.ddl.DropTableStatement;
+
+/**
+ * The type Drop table statement meta data refresh.
+ */
+public final class DropTableStatementMetaDataRefresh implements SQLStatementMetaDataRefresh<DropTableStatement> {
+    
+    @Override
+    public void refreshMetaData(final ShardingRuntimeContext shardingRuntimeContext, final SQLStatementContext<DropTableStatement> sqlStatementContext) {
+        for (SimpleTableSegment each : sqlStatementContext.getSqlStatement().getTables()) {
+            shardingRuntimeContext.getMetaData().getSchema().remove(each.getTableName().getIdentifier().getValue());
+        }
+    }
+    
 
 Review comment:
   Please remove useless line

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #5019: ues strategy pattern modify refresh ShardingMetaData.

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #5019:  ues strategy pattern modify refresh ShardingMetaData.
URL: https://github.com/apache/incubator-shardingsphere/pull/5019#discussion_r400848411
 
 

 ##########
 File path: sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/refreh/AbstractTableStatementMetaData.java
 ##########
 @@ -0,0 +1,38 @@
+package org.apache.shardingsphere.shardingjdbc.jdbc.refreh;
+
+import org.apache.shardingsphere.core.metadata.ShardingMetaDataLoader;
+import org.apache.shardingsphere.core.metadata.ShardingTableMetaDataDecorator;
+import org.apache.shardingsphere.core.rule.ShardingRule;
+import org.apache.shardingsphere.encrypt.metadata.EncryptTableMetaDataDecorator;
+import org.apache.shardingsphere.shardingjdbc.jdbc.core.context.ShardingRuntimeContext;
+import org.apache.shardingsphere.sql.parser.binder.metadata.table.TableMetaData;
+import org.apache.shardingsphere.underlying.common.config.properties.ConfigurationPropertyKey;
+
+import java.sql.SQLException;
+
+/**
+ * The type Abstract table statement meta data.
+ */
+public abstract class AbstractTableStatementMetaData {
+    
+    /**
+     * Load table meta table meta data.
+     *
+     * @param tableName              the table name
 
 Review comment:
   It looks like not fixed yet.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #5019: ues strategy pattern modify refresh ShardingMetaData.

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #5019:  ues strategy pattern modify refresh ShardingMetaData.
URL: https://github.com/apache/incubator-shardingsphere/pull/5019#discussion_r400852116
 
 

 ##########
 File path: sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/refreh/SQLStatementMetaDataRefresh.java
 ##########
 @@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.shardingjdbc.jdbc.refreh;
+
+import org.apache.shardingsphere.shardingjdbc.jdbc.core.context.ShardingRuntimeContext;
+import org.apache.shardingsphere.sql.parser.binder.statement.SQLStatementContext;
+import org.apache.shardingsphere.sql.parser.sql.statement.SQLStatement;
+
+import java.sql.SQLException;
+
+/**
+ * The interface SQL statement meta data refresh.
+ *
+ * @param <T> the type parameter
+ */
+public interface SQLStatementMetaDataRefresh<T extends SQLStatement> {
 
 Review comment:
   Class name should be noun

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] yu199195 commented on a change in pull request #5019: ues strategy pattern modify refresh ShardingMetaData.

Posted by GitBox <gi...@apache.org>.
yu199195 commented on a change in pull request #5019:  ues strategy pattern modify refresh ShardingMetaData.
URL: https://github.com/apache/incubator-shardingsphere/pull/5019#discussion_r400825089
 
 

 ##########
 File path: sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/refreh/AbstractTableStatementMetaData.java
 ##########
 @@ -0,0 +1,38 @@
+package org.apache.shardingsphere.shardingjdbc.jdbc.refreh;
+
+import org.apache.shardingsphere.core.metadata.ShardingMetaDataLoader;
+import org.apache.shardingsphere.core.metadata.ShardingTableMetaDataDecorator;
+import org.apache.shardingsphere.core.rule.ShardingRule;
+import org.apache.shardingsphere.encrypt.metadata.EncryptTableMetaDataDecorator;
+import org.apache.shardingsphere.shardingjdbc.jdbc.core.context.ShardingRuntimeContext;
+import org.apache.shardingsphere.sql.parser.binder.metadata.table.TableMetaData;
+import org.apache.shardingsphere.underlying.common.config.properties.ConfigurationPropertyKey;
+
+import java.sql.SQLException;
+
+/**
+ * The type Abstract table statement meta data.
+ */
+public abstract class AbstractTableStatementMetaData {
+    
+    /**
+     * Load table meta table meta data.
+     *
+     * @param tableName              the table name
 
 Review comment:
   fix it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #5019: ues strategy pattern modify refresh ShardingMetaData.

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #5019:  ues strategy pattern modify refresh ShardingMetaData.
URL: https://github.com/apache/incubator-shardingsphere/pull/5019#discussion_r400775754
 
 

 ##########
 File path: sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/refreh/SQLStatementMetaDataRefreshFactory.java
 ##########
 @@ -0,0 +1,39 @@
+package org.apache.shardingsphere.shardingjdbc.jdbc.refreh;
+
+import org.apache.shardingsphere.sql.parser.binder.statement.SQLStatementContext;
+import org.apache.shardingsphere.sql.parser.binder.statement.ddl.AlterTableStatementContext;
+import org.apache.shardingsphere.sql.parser.binder.statement.ddl.CreateIndexStatementContext;
+import org.apache.shardingsphere.sql.parser.binder.statement.ddl.CreateTableStatementContext;
+import org.apache.shardingsphere.sql.parser.binder.statement.ddl.DropIndexStatementContext;
+import org.apache.shardingsphere.sql.parser.binder.statement.ddl.DropTableStatementContext;
+import org.apache.shardingsphere.sql.parser.sql.statement.SQLStatement;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Optional;
+
+/**
+ * The type Sql statement meta data refresh factory.
+ */
+public final class SQLStatementMetaDataRefreshFactory {
+    
+    private static final Map<Class<?>, SQLStatementMetaDataRefresh<? extends SQLStatement>> REFRESH_MAP = new HashMap<>();
+    
+    static {
+        REFRESH_MAP.put(CreateTableStatementContext.class, new CreateTableStatementMetaDataRefresh());
+        REFRESH_MAP.put(AlterTableStatementContext.class, new AlterTableStatementMetaDataRefresh());
+        REFRESH_MAP.put(DropTableStatementContext.class, new DropTableStatementMetaDataRefresh());
+        REFRESH_MAP.put(CreateIndexStatementContext.class, new CreateIndexStatementMetaDataRefresh());
+        REFRESH_MAP.put(DropIndexStatementContext.class, new DropIndexStatementMetaDataRefresh());
+    }
+    
+    /**
+     * New instance sql statement meta data refresh.
 
 Review comment:
   `sql` should be `SQL` in javadoc

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #5019: ues strategy pattern modify refresh ShardingMetaData.

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #5019:  ues strategy pattern modify refresh ShardingMetaData.
URL: https://github.com/apache/incubator-shardingsphere/pull/5019
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #5019: ues strategy pattern modify refresh ShardingMetaData.

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #5019:  ues strategy pattern modify refresh ShardingMetaData.
URL: https://github.com/apache/incubator-shardingsphere/pull/5019#discussion_r400774953
 
 

 ##########
 File path: sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/refreh/AbstractTableStatementMetaData.java
 ##########
 @@ -0,0 +1,38 @@
+package org.apache.shardingsphere.shardingjdbc.jdbc.refreh;
+
+import org.apache.shardingsphere.core.metadata.ShardingMetaDataLoader;
+import org.apache.shardingsphere.core.metadata.ShardingTableMetaDataDecorator;
+import org.apache.shardingsphere.core.rule.ShardingRule;
+import org.apache.shardingsphere.encrypt.metadata.EncryptTableMetaDataDecorator;
+import org.apache.shardingsphere.shardingjdbc.jdbc.core.context.ShardingRuntimeContext;
+import org.apache.shardingsphere.sql.parser.binder.metadata.table.TableMetaData;
+import org.apache.shardingsphere.underlying.common.config.properties.ConfigurationPropertyKey;
+
+import java.sql.SQLException;
+
+/**
+ * The type Abstract table statement meta data.
+ */
+public abstract class AbstractTableStatementMetaData {
+    
+    /**
+     * Load table meta table meta data.
+     *
+     * @param tableName              the table name
 
 Review comment:
   Please reference other javadoc and make them consist

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] yu199195 commented on a change in pull request #5019: ues strategy pattern modify refresh ShardingMetaData.

Posted by GitBox <gi...@apache.org>.
yu199195 commented on a change in pull request #5019:  ues strategy pattern modify refresh ShardingMetaData.
URL: https://github.com/apache/incubator-shardingsphere/pull/5019#discussion_r400825063
 
 

 ##########
 File path: sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/refreh/DropTableStatementMetaDataRefresh.java
 ##########
 @@ -0,0 +1,20 @@
+package org.apache.shardingsphere.shardingjdbc.jdbc.refreh;
+
+import org.apache.shardingsphere.shardingjdbc.jdbc.core.context.ShardingRuntimeContext;
+import org.apache.shardingsphere.sql.parser.binder.statement.SQLStatementContext;
+import org.apache.shardingsphere.sql.parser.sql.segment.generic.table.SimpleTableSegment;
+import org.apache.shardingsphere.sql.parser.sql.statement.ddl.DropTableStatement;
+
+/**
+ * The type Drop table statement meta data refresh.
+ */
+public final class DropTableStatementMetaDataRefresh implements SQLStatementMetaDataRefresh<DropTableStatement> {
+    
+    @Override
+    public void refreshMetaData(final ShardingRuntimeContext shardingRuntimeContext, final SQLStatementContext<DropTableStatement> sqlStatementContext) {
+        for (SimpleTableSegment each : sqlStatementContext.getSqlStatement().getTables()) {
+            shardingRuntimeContext.getMetaData().getSchema().remove(each.getTableName().getIdentifier().getValue());
+        }
+    }
+    
 
 Review comment:
   ok，fix it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #5019: ues strategy pattern modify refresh ShardingMetaData.

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #5019:  ues strategy pattern modify refresh ShardingMetaData.
URL: https://github.com/apache/incubator-shardingsphere/pull/5019#issuecomment-606571754
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5019?src=pr&el=h1) Report
   > Merging [#5019](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5019?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/f0a3128909cd7d1c019720e5c1da13a4a32b27f9&el=desc) will **increase** coverage by `0.06%`.
   > The diff coverage is `27.58%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5019/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5019?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5019      +/-   ##
   ============================================
   + Coverage     53.83%   53.90%   +0.06%     
   - Complexity      395      401       +6     
   ============================================
     Files          1146     1153       +7     
     Lines         20409    20413       +4     
     Branches       3710     3703       -7     
   ============================================
   + Hits          10988    11004      +16     
   + Misses         8745     8737       -8     
   + Partials        676      672       -4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5019?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...jdbc/refreh/DropIndexStatementMetaDataRefresh.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5019/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL3JlZnJlaC9Ecm9wSW5kZXhTdGF0ZW1lbnRNZXRhRGF0YVJlZnJlc2guamF2YQ==) | `6.66% <6.66%> (ø)` | `1.00 <1.00> (?)` | |
   | [...bc/jdbc/refreh/AbstractTableStatementMetaData.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5019/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL3JlZnJlaC9BYnN0cmFjdFRhYmxlU3RhdGVtZW50TWV0YURhdGEuamF2YQ==) | `10.00% <10.00%> (ø)` | `1.00 <1.00> (?)` | |
   | [...bc/refreh/CreateIndexStatementMetaDataRefresh.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5019/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL3JlZnJlaC9DcmVhdGVJbmRleFN0YXRlbWVudE1ldGFEYXRhUmVmcmVzaC5qYXZh) | `14.28% <14.28%> (ø)` | `1.00 <1.00> (?)` | |
   | [...jdbc/refreh/DropTableStatementMetaDataRefresh.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5019/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL3JlZnJlaC9Ecm9wVGFibGVTdGF0ZW1lbnRNZXRhRGF0YVJlZnJlc2guamF2YQ==) | `20.00% <20.00%> (ø)` | `1.00 <1.00> (?)` | |
   | [...dbc/refreh/AlterTableStatementMetaDataRefresh.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5019/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL3JlZnJlaC9BbHRlclRhYmxlU3RhdGVtZW50TWV0YURhdGFSZWZyZXNoLmphdmE=) | `25.00% <25.00%> (ø)` | `1.00 <1.00> (?)` | |
   | [...bc/refreh/CreateTableStatementMetaDataRefresh.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5019/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL3JlZnJlaC9DcmVhdGVUYWJsZVN0YXRlbWVudE1ldGFEYXRhUmVmcmVzaC5qYXZh) | `25.00% <25.00%> (ø)` | `1.00 <1.00> (?)` | |
   | [...ardingjdbc/executor/AbstractStatementExecutor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5019/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9leGVjdXRvci9BYnN0cmFjdFN0YXRlbWVudEV4ZWN1dG9yLmphdmE=) | `92.85% <33.33%> (+51.99%)` | `0.00 <0.00> (ø)` | |
   | [...dbc/refreh/SQLStatementMetaDataRefreshFactory.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5019/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL3JlZnJlaC9TUUxTdGF0ZW1lbnRNZXRhRGF0YVJlZnJlc2hGYWN0b3J5LmphdmE=) | `88.88% <88.88%> (ø)` | `0.00 <0.00> (?)` | |
   | [...jdbc/jdbc/core/context/ShardingRuntimeContext.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5019/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvY29udGV4dC9TaGFyZGluZ1J1bnRpbWVDb250ZXh0LmphdmE=) | `84.21% <100.00%> (+0.87%)` | `0.00 <0.00> (ø)` | |
   | ... and [6 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5019/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5019?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5019?src=pr&el=footer). Last update [f0a3128...b9bf8ce](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5019?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #5019: ues strategy pattern modify refresh ShardingMetaData.

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5019:  ues strategy pattern modify refresh ShardingMetaData.
URL: https://github.com/apache/incubator-shardingsphere/pull/5019#issuecomment-606573625
 
 
   ## Pull Request Test Coverage Report for [Build 10738](https://coveralls.io/builds/29737531)
   
   * **17** of **58**   **(29.31%)**  changed or added relevant lines in **9** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.05%**) to **57.263%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/executor/AbstractStatementExecutor.java](https://coveralls.io/builds/29737531/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fexecutor%2FAbstractStatementExecutor.java#L153) | 2 | 3 | 66.67%
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/refreh/SQLStatementMetaDataRefreshFactory.java](https://coveralls.io/builds/29737531/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Frefreh%2FSQLStatementMetaDataRefreshFactory.java#L35) | 8 | 9 | 88.89%
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/refreh/AlterTableStatementMetaDataRefresh.java](https://coveralls.io/builds/29737531/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Frefreh%2FAlterTableStatementMetaDataRefresh.java#L33) | 1 | 4 | 25.0%
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/refreh/CreateTableStatementMetaDataRefresh.java](https://coveralls.io/builds/29737531/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Frefreh%2FCreateTableStatementMetaDataRefresh.java#L33) | 1 | 4 | 25.0%
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/refreh/DropTableStatementMetaDataRefresh.java](https://coveralls.io/builds/29737531/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Frefreh%2FDropTableStatementMetaDataRefresh.java#L32) | 1 | 5 | 20.0%
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/refreh/CreateIndexStatementMetaDataRefresh.java](https://coveralls.io/builds/29737531/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Frefreh%2FCreateIndexStatementMetaDataRefresh.java#L32) | 1 | 7 | 14.29%
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/refreh/AbstractTableStatementMetaData.java](https://coveralls.io/builds/29737531/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Frefreh%2FAbstractTableStatementMetaData.java#L44) | 1 | 10 | 10.0%
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/refreh/DropIndexStatementMetaDataRefresh.java](https://coveralls.io/builds/29737531/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Frefreh%2FDropIndexStatementMetaDataRefresh.java#L38) | 1 | 15 | 6.67%
   <!-- | **Total:** | **17** | **58** | **29.31%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29737531/badge)](https://coveralls.io/builds/29737531) |
   | :-- | --: |
   | Change from base [Build 10733](https://coveralls.io/builds/29736503): |  0.05% |
   | Covered Lines: | 11689 |
   | Relevant Lines: | 20413 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services