You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by we...@apache.org on 2026/05/10 01:01:22 UTC

(spark) branch master updated: [SPARK-56806][BUILD] Fix `jetty-proxy` artifact ID in `core/pom.xml`'s `includeArtifactIds`

This is an automated email from the ASF dual-hosted git repository.

cloud-fan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 8d5f3fd7200d [SPARK-56806][BUILD] Fix `jetty-proxy` artifact ID in `core/pom.xml`'s `includeArtifactIds`
8d5f3fd7200d is described below

commit 8d5f3fd7200d9591a15c7094a5ce5207b6895819
Author: Wenchen Fan <we...@databricks.com>
AuthorDate: Sun May 10 09:01:03 2026 +0800

    [SPARK-56806][BUILD] Fix `jetty-proxy` artifact ID in `core/pom.xml`'s `includeArtifactIds`
    
    ### What changes were proposed in this pull request?
    
    In `core/pom.xml`, the `<includeArtifactIds>` list under the `maven-dependency-plugin`'s `copy-dependencies` execution still references the old artifact ID `jetty-proxy`, while the actual `<dependency>` declared in the same file (and the corresponding `<include>` in the `maven-shade-plugin`) both use the renamed `jetty-ee10-proxy`. This PR renames `jetty-proxy` → `jetty-ee10-proxy` in the `<includeArtifactIds>` list to keep all three locations consistent.
    
    ### Why are the changes needed?
    
    Because there is no longer any artifact with id `jetty-proxy` on the classpath, the `copy-dependencies` execution silently skips the proxy JAR. With `SPARK_PREPEND_CLASSES`, Spark relies on the unshaded original JARs being copied to `target/`, so the proxy JAR is missing in that mode. Renaming the entry restores the intended behavior.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No. Build-only fix.
    
    ### How was this patch tested?
    
    Existing build. Verified that the dependency block (`org.eclipse.jetty.ee10:jetty-ee10-proxy`) and the `maven-shade-plugin` `<include>` already use the same renamed artifact ID.
    
    ### Was this patch authored or co-authored using generative AI tooling?
    
    Generated-by: Claude Code (claude-opus-4-7)
    
    Closes #55779 from cloud-fan/SPARK-jetty-proxy-includeartifactids.
    
    Authored-by: Wenchen Fan <we...@databricks.com>
    Signed-off-by: Wenchen Fan <we...@databricks.com>
---
 core/pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/pom.xml b/core/pom.xml
index 7c275a0ae643..88f6525b8caf 100644
--- a/core/pom.xml
+++ b/core/pom.xml
@@ -561,7 +561,7 @@
               <overWriteIfNewer>true</overWriteIfNewer>
               <useSubDirectoryPerType>true</useSubDirectoryPerType>
               <includeArtifactIds>
-                guava,protobuf-java,jetty-io,jetty-ee10-servlet,jetty-ee10-servlets,jetty-http,jetty-ee10-plus,jetty-util,jetty-server,jetty-security,jetty-proxy,jetty-client,jetty-session,jetty-compression-server,jetty-compression-common,jetty-compression-gzip
+                guava,protobuf-java,jetty-io,jetty-ee10-servlet,jetty-ee10-servlets,jetty-http,jetty-ee10-plus,jetty-util,jetty-server,jetty-security,jetty-ee10-proxy,jetty-client,jetty-session,jetty-compression-server,jetty-compression-common,jetty-compression-gzip
               </includeArtifactIds>
               <silent>true</silent>
             </configuration>


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org