You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/30 06:43:06 UTC

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6543: net_if: add IFF_LOOPBACK/POINTOPOINT/MULTICAST/BROADCAST

pkarashchenko commented on code in PR #6543:
URL: https://github.com/apache/incubator-nuttx/pull/6543#discussion_r910661429


##########
include/net/if.h:
##########
@@ -51,27 +51,43 @@
 #define IFF_RUNNING        (1 << 2) /* Carrier is available */
 #define IFF_IPv6           (1 << 3) /* Configured for IPv6 packet (vs ARP or IPv4) */
 #define IFF_BOUND          (1 << 4) /* Bound to a socket */
+#define IFF_LOOPBACK       (1 << 5) /* Is a loopback net */
+#define IFF_POINTOPOINT    (1 << 6) /* Is point-to-point link */
 #define IFF_NOARP          (1 << 7) /* ARP is not required for this packet */
+#define IFF_MULTICAST      (1 <<12) /* Supports multicast. */

Review Comment:
   Maybe add extra space `1 << 12` and align comments accordingly?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org