You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/12/10 07:16:18 UTC

[GitHub] eolivelli commented on a change in pull request #1875: [stats][doc] Add @StatsDoc annotation for garbage collector stats

eolivelli commented on a change in pull request #1875: [stats][doc] Add @StatsDoc annotation for garbage collector stats
URL: https://github.com/apache/bookkeeper/pull/1875#discussion_r240101877
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java
 ##########
 @@ -69,7 +66,7 @@
  *
  * <p>TODO: eliminate the direct usage of zookeeper here {@link https://github.com/apache/bookkeeper/issues/1331}
  */
-public class ScanAndCompareGarbageCollector implements GarbageCollector{
+public class ScanAndCompareGarbageCollector implements GarbageCollector, Supplier<Integer> {
 
 Review comment:
   'Supplier' is not very clear, I see we have only one value to report, but maybe this is not a good reason.
   What do you think?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services