[GitHub] chetanmeh opened a new issue #3770: Improve attachment inlining logic

[GitBox <gi...@apache.org>]

chetanmeh opened a new issue #3770: Improve attachment inlining logic
URL: https://github.com/apache/incubator-openwhisk/issues/3770
 
 
   Current attachment inlining approach as implemented in #3709 introduces lots of overhead and thus slows down the upload flow which leads to failures as seen in #3769
   
   Currently it does following things
   
   1. Convert the Source of `ByteString` to Source of `byte`
   2. Check if overall bytes are less than maxInlineSize or not 
   3. If not then re assemble the bytes to create a `ByteString`
   
   Due to this a 100kb attachment which takes 25 ms without inline flow takes 60 secs with inline flow. As a fix we need to avoid this conversion to from ByteString -> byte -> ByteString and work at ByteString level only. 
   
   As a temporary fix by default inlining would be disabled and once the performance issues are addressed it would be enabled again
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services