You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "orionlibs (via GitHub)" <gi...@apache.org> on 2023/07/13 17:25:04 UTC

[GitHub] [commons-numbers] orionlibs opened a new pull request, #133: [NUMB-194] GCD JavaDoc mention coprimes check

orionlibs opened a new pull request, #133:
URL: https://github.com/apache/commons-numbers/pull/133

   [NUMB-194](https://issues.apache.org/jira/browse/NUMBERS-194) - Changed JavaDoc of the GCD methods to mention that they can be used to determine if 2 numbers are relatively prime or coprime


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-numbers] orionlibs commented on a diff in pull request #133: NUMBERS-194: GCD JavaDoc mention coprimes check

Posted by "orionlibs (via GitHub)" <gi...@apache.org>.
orionlibs commented on code in PR #133:
URL: https://github.com/apache/commons-numbers/pull/133#discussion_r1265957810


##########
commons-numbers-core/src/main/java/org/apache/commons/numbers/core/ArithmeticUtils.java:
##########
@@ -58,6 +58,8 @@ private ArithmeticUtils() {
      *   for the special cases above.</li>
      *  <li>The invocation {@code gcd(0, 0)} is the only one which returns
      *   {@code 0}.</li>
+     *   <li>gcd can be used to determine if two numbers are relatively prime.

Review Comment:
   @aherbert fixed JavaDoc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-numbers] aherbert commented on a diff in pull request #133: NUMBERS-194: GCD JavaDoc mention coprimes check

Posted by "aherbert (via GitHub)" <gi...@apache.org>.
aherbert commented on code in PR #133:
URL: https://github.com/apache/commons-numbers/pull/133#discussion_r1263045991


##########
commons-numbers-core/src/main/java/org/apache/commons/numbers/core/ArithmeticUtils.java:
##########
@@ -58,6 +58,8 @@ private ArithmeticUtils() {
      *   for the special cases above.</li>
      *  <li>The invocation {@code gcd(0, 0)} is the only one which returns
      *   {@code 0}.</li>
+     *   <li>gcd can be used to determine if two numbers are relatively prime.

Review Comment:
   This has been added as a special case. It is not a special case, it is a usage example. It should be moved to a new paragraph, e.g.
   ```
   <p>Two numbers are relatively prime, or coprime, if their gcd is 1.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-numbers] asfgit closed pull request #133: NUMBERS-194: GCD JavaDoc mention coprimes check

Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #133: NUMBERS-194: GCD JavaDoc mention coprimes check
URL: https://github.com/apache/commons-numbers/pull/133


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-numbers] codecov-commenter commented on pull request #133: NUMBERS-194: GCD JavaDoc mention coprimes check

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #133:
URL: https://github.com/apache/commons-numbers/pull/133#issuecomment-1638991702

   ## [Codecov](https://app.codecov.io/gh/apache/commons-numbers/pull/133?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#133](https://app.codecov.io/gh/apache/commons-numbers/pull/133?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c9e905f) into [master](https://app.codecov.io/gh/apache/commons-numbers/commit/447138604bb57541fe24d0b0ac5e6d838f2935c2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4471386) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff            @@
   ##             master     #133   +/-   ##
   =========================================
     Coverage     99.14%   99.14%           
     Complexity     1681     1681           
   =========================================
     Files            65       65           
     Lines          4305     4305           
     Branches        854      854           
   =========================================
     Hits           4268     4268           
     Misses           10       10           
     Partials         27       27           
   ```
   
   
   | [Impacted Files](https://app.codecov.io/gh/apache/commons-numbers/pull/133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...g/apache/commons/numbers/core/ArithmeticUtils.java](https://app.codecov.io/gh/apache/commons-numbers/pull/133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9ucy1udW1iZXJzLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbnVtYmVycy9jb3JlL0FyaXRobWV0aWNVdGlscy5qYXZh) | `99.40% <ø> (ø)` | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org