[jira] [Updated] (CASSANDRA-15798) Only calculate 1.0 + dynamicBadnessThreshold once per loop in DynamicEndpointSnitch

["Jordan West (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CASSANDRA-15798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jordan West updated CASSANDRA-15798:
------------------------------------
     Bug Category: Parent values: Degradation(12984)Level 1 values: Performance Bug/Regression(12997)
       Complexity: Low Hanging Fruit
    Discovered By: User Report
    Fix Version/s: 4.0-beta
         Severity: Low
           Status: Open  (was: Triage Needed)

> Only calculate 1.0 + dynamicBadnessThreshold once per loop in DynamicEndpointSnitch
> -----------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-15798
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15798
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Messaging/Internode
>            Reporter: Jordan West
>            Assignee: Jordan West
>            Priority: Normal
>             Fix For: 4.0-beta
>
>
> The change to make dynamicBadnessThreshold volatile and mutable in https://issues.apache.org/jira/browse/CASSANDRA-12179 could have minor implications for the performance of this code: https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/locator/DynamicEndpointSnitch.java#L216. Its better to calculate this once before the loop starts, which has the added benefit that the value is stable throughout the calculation as well. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org