You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by bt...@gmail.com on 2012/06/13 16:03:57 UTC

Re: Pass token on listMethods to enable allowUnauthenticated=false (issue 6306074)

On 2012/06/13 13:40:57, rbaxter85 wrote:
> On 2012/06/13 12:49:11, btlillie wrote:

> LGTM.  Out of curiosity, are there no unit tests for this code?

> Brian could you add the dev list as well?

There was nothing that specifically tests whether a token was present or
not, or was added.  Without a constructor change, the existing tests did
not require updates.

There are no tests specifically for allowUnauthenticated=false,
especially in conjunction with the system.listMethods requests.

http://codereview.appspot.com/6306074/