You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2018/07/13 17:00:37 UTC

[GitHub] vdiravka commented on issue #1382: DRILL-5495: convert_from function on top of int96 data results in Arr…

vdiravka commented on issue #1382: DRILL-5495: convert_from function on top of int96 data results in Arr…
URL: https://github.com/apache/drill/pull/1382#issuecomment-404892801
 
 
   @arina-ielchiieva Yes, it is mechanical issue. 
   `recordsToReadInThisPass` is `numNonNullValues` (see `NullableColumnReader#processPagesBulk():284`)
   But `recordsReadInThisIteration` is `numNullValues` + `numNonNullValues`. 
   In `NullableColumnReader#readField()` the only `numNonNullValues` should be used.
   
   It is hard to reproduce the issue with one small file. But since it was the mechanical error, I think it is fine do not add unit test for this issue. I have updated the PR.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services