You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@streampark.apache.org by GitBox <gi...@apache.org> on 2022/11/05 02:47:46 UTC

[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #1951: [Improve] Unified Mapper

wolfboys commented on code in PR #1951:
URL: https://github.com/apache/incubator-streampark/pull/1951#discussion_r1014552326


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ApplicationServiceImpl.java:
##########
@@ -1029,7 +1033,13 @@ public String getMain(Application application) {
     @Override
     @RefreshCache
     public boolean mapping(Application appParam) {
-        boolean mapping = this.baseMapper.mapping(appParam);
+        appParam.setAppId(appParam.getAppId());
+        appParam.setJobId(appParam.getJobId());
+        appParam.setState(14);

Review Comment:
   you can improve the code: `appParam.setState(FlinkAppState.MAPPING.getValue());`
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org