[GitHub] [pulsar] eolivelli commented on a diff in pull request #17243: [improve][cli] Pulsar shell: support for Windows

[GitBox <gi...@apache.org>]

eolivelli commented on code in PR #17243:
URL: https://github.com/apache/pulsar/pull/17243#discussion_r953468968


##########
pulsar-client-tools/src/main/java/org/apache/pulsar/shell/PulsarShell.java:
##########
@@ -216,7 +216,6 @@ public void reload(Properties properties) throws Exception {
     }
 
     public void run() throws Exception {
-        System.setProperty("org.jline.terminal.dumb", "true");

Review Comment:
   what's the impact on Linux and Mac ?



##########
pom.xml:
##########
@@ -211,7 +211,7 @@ flexible messaging model and an intuitive client API.</description>
     <jakarta.activation.version>1.2.2</jakarta.activation.version>
     <jakarta.xml.bind.version>2.3.3</jakarta.xml.bind.version>
     <jakarta.validation.version>2.0.2</jakarta.validation.version>
-    <jna.version>4.2.0</jna.version>
+    <jna.version>5.12.1</jna.version>

Review Comment:
   I would move this change to a separate PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org