[GitHub] [maven] slawekjaranowski commented on a diff in pull request #758: [MNG-7504] Don't print warning unsupported reportPlugins for m-site-p

[GitBox <gi...@apache.org>]

slawekjaranowski commented on code in PR #758:
URL: https://github.com/apache/maven/pull/758#discussion_r901838788


##########
maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultMojoExecutionConfigurator.java:
##########
@@ -151,28 +151,42 @@ private void checkUnknownMojoConfigurationParameters( MojoExecution mojoExecutio
 
         unknownParameters = getUnknownParameters( mojoExecution, parametersNamesAll );
 
-        unknownParameters.forEach(
-            name ->
-            {
-                MessageBuilder messageBuilder = MessageUtils.buffer()
-                    .warning( "Parameter '" )
-                    .warning( name )
-                    .warning( "' is unknown for plugin '" )
-                    .warning( mojoExecution.getArtifactId() ).warning( ":" )
-                    .warning( mojoExecution.getVersion() ).warning( ":" )
-                    .warning( mojoExecution.getGoal() );
-
-                if ( mojoExecution.getExecutionId() != null )
+        unknownParameters.stream()
+            .filter( parameterName -> isNotReportPluginsForMavenSite( parameterName, mojoExecution ) )
+            .forEach(
+                name ->
                 {
-                    messageBuilder.warning( " (" );
-                    messageBuilder.warning( mojoExecution.getExecutionId() );
-                    messageBuilder.warning( ")" );
-                }
-
-                messageBuilder.warning( "'" );
+                    MessageBuilder messageBuilder = MessageUtils.buffer()
+                        .warning( "Parameter '" )
+                        .warning( name )
+                        .warning( "' is unknown for plugin '" )
+                        .warning( mojoExecution.getArtifactId() ).warning( ":" )
+                        .warning( mojoExecution.getVersion() ).warning( ":" )
+                        .warning( mojoExecution.getGoal() );
+
+                    if ( mojoExecution.getExecutionId() != null )
+                    {
+                        messageBuilder.warning( " (" );
+                        messageBuilder.warning( mojoExecution.getExecutionId() );
+                        messageBuilder.warning( ")" );
+                    }
+
+                    messageBuilder.warning( "'" );
+
+                    logger.warn( messageBuilder.toString() );
+                } );
+    }
 
-                logger.warn( messageBuilder.toString() );
-            } );
+    /**
+     * Method can be removed after {@link org.apache.maven.model.plugin.ReportingConverter} will be removed or disabled

Review Comment:
   Not yet.
   
   Now  - I think that this commit can be for 3.9.x
   And in 4.x we can drop ReportingConverter - with new issue.
   
   What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org