You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Jesus Camacho Rodriguez (Jira)" <ji...@apache.org> on 2020/03/07 00:05:00 UTC

[jira] [Comment Edited] (CALCITE-3825) Split AbstractMaterializedViewRule into multiple classes

    [ https://issues.apache.org/jira/browse/CALCITE-3825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17046157#comment-17046157 ] 

Jesus Camacho Rodriguez edited comment on CALCITE-3825 at 3/7/20, 12:04 AM:
----------------------------------------------------------------------------

Fixed in https://github.com/apache/calcite/commit/5dea67890a1916771e9a335e45969f2a4d4f7d3c .


was (Author: jcamachorodriguez):
Fixed in https://github.com/apache/calcite/commit/efa5cb7ba6a754ef98281f4f142c16d895a49df4 .

> Split AbstractMaterializedViewRule into multiple classes
> --------------------------------------------------------
>
>                 Key: CALCITE-3825
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3825
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> AbstractMaterializedViewRule contains a materialized view-based rewriting algorithm that has been there for multiple releases and it is used by some engines relying in Calcite, e.g., Apache Hive.
> The main reason to have a single file/class for the rule was to make the logic self-contained instead of spreading it between multiple files from the onset, as it was experimental and we were not sure how far the implementation would go. In retrospective, we should have refactored that code sooner rather than later, since it makes very difficult to understand and maintain logic that is already complicated enough.
> This issue is to split AbstractMaterializedViewRule into multiple files/classes (it already contained multiple internal classes).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)