You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zhannngchen (via GitHub)" <gi...@apache.org> on 2023/06/13 14:20:21 UTC

[GitHub] [doris] zhannngchen commented on a diff in pull request #20720: [Fix](MOW) Fix load data publish timeout when enable unique key MOW

zhannngchen commented on code in PR #20720:
URL: https://github.com/apache/doris/pull/20720#discussion_r1228127333


##########
be/src/olap/delta_writer.cpp:
##########
@@ -456,7 +450,20 @@ Status DeltaWriter::close_wait(const PSlaveTabletNodes& slave_tablet_nodes,
             // calculate delete bitmap between segments
             RETURN_IF_ERROR(_tablet->calc_delete_bitmap_between_segments(_cur_rowset, segments,
                                                                          _delete_bitmap));
+            RETURN_IF_ERROR(_tablet->commit_phase_update_delete_bitmap(
+                    _cur_rowset, _rowset_ids, _delete_bitmap, _cur_max_version, segments,

Review Comment:
   `_cur_max_version` is inited at `DeltaWriter::init()`, it's not the latest max version



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org