You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/09/07 17:22:18 UTC

[GitHub] Fokko commented on a change in pull request #3860: [AIRFLOW-3025] Enable specifying dns and dns_search options for DockerOperator

Fokko commented on a change in pull request #3860: [AIRFLOW-3025] Enable specifying dns and dns_search options for DockerOperator
URL: https://github.com/apache/incubator-airflow/pull/3860#discussion_r216030227
 
 

 ##########
 File path: airflow/operators/docker_operator.py
 ##########
 @@ -110,6 +114,8 @@ def __init__(
             api_version=None,
             command=None,
             cpus=1.0,
+            dns=None,
+            dns_search=None,
 
 Review comment:
   Can you move this to the end of the argument list, so we keep is as much as possible backward compatible?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services