You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by mi...@icw.de on 2011/04/27 16:11:05 UTC

Consumer and Producer names in JMX

Hello Camel devs, 

Currently the consumer and producer names in JMX have a name based on 
their java instance [1]. Due to this it is not obvious what is the 
endpoint  of the consumers/producers.

Would not it be better to use name based on endpoint URI of the 
consumer/producer endpoints (combined with identityHashcode) instead?


[1] Copy/paste from the DefaultManagementNamingStrategy

...
   String name = consumer.getClass().getSimpleName();
        if (ObjectHelper.isEmpty(name)) {
            name = "Consumer";
        }
        buffer.append(KEY_NAME + "=")
            .append(name)
            .append("(").append(ObjectHelper.getIdentityHashCode
(consumer)).append(")");

...

Regards, 
Mitko



�� 
InterComponentWare AG:  
Vorstand: Peter Kirschbauer (Vors.), J�rg Stadler  
Aufsichtsratsvors.: Prof. Dr. Christof Hettich  
Firmensitz: 69190 Walldorf, Altrottstra�e 31  
AG Mannheim HRB 351761 / USt.-IdNr.: DE 198388516  

Re: Consumer and Producer names in JMX

Posted by Claus Ibsen <cl...@gmail.com>.
On Wed, Apr 27, 2011 at 4:40 PM,  <mi...@icw.de> wrote:
> Hi Claus,
>
> It's about the name that is shown in the JMX tree uner
> org.apache.camel/consumers/context/consumerName (see the code snppet)
>
> There is an endpoint uri attribute in the jmx objects, but it does not
> help navigate. One has to expand the jmx Consumer/Producer objects to find
> to which endpoint they belong.
>

Yeah I think we can improve that as it helps in the overview to faster
spot the desired consumer.
Fell free to create a JIRA ticket

> Regards,
> Mitko
>
>
>
>
> From:
> Claus Ibsen <cl...@gmail.com>
> To:
> dev@camel.apache.org
> Date:
> 27.04.2011 16:17
> Subject:
> Re: Consumer and Producer names in JMX
>
>
>
> They have an endpoint uri attribute.
>
>
> On Wed, Apr 27, 2011 at 4:11 PM,  <mi...@icw.de> wrote:
>> Hello Camel devs,
>>
>> Currently the consumer and producer names in JMX have a name based on
>> their java instance [1]. Due to this it is not obvious what is the
>> endpoint  of the consumers/producers.
>>
>> Would not it be better to use name based on endpoint URI of the
>> consumer/producer endpoints (combined with identityHashcode) instead?
>>
>>
>> [1] Copy/paste from the DefaultManagementNamingStrategy
>>
>> ...
>>   String name = consumer.getClass().getSimpleName();
>>        if (ObjectHelper.isEmpty(name)) {
>>            name = "Consumer";
>>        }
>>        buffer.append(KEY_NAME + "=")
>>            .append(name)
>>            .append("(").append(ObjectHelper.getIdentityHashCode
>> (consumer)).append(")");
>>
>> ...
>>
>> Regards,
>> Mitko
>>
>>
>>
>>
>> InterComponentWare AG:
>> Vorstand: Peter Kirschbauer (Vors.), Jörg Stadler
>> Aufsichtsratsvors.: Prof. Dr. Christof Hettich
>> Firmensitz: 69190 Walldorf, Altrottstraße 31
>> AG Mannheim HRB 351761 / USt.-IdNr.: DE 198388516
>
>
>
> --
> Claus Ibsen
> -----------------
> FuseSource
> Email: cibsen@fusesource.com
> Web: http://fusesource.com
> CamelOne 2011: http://fusesource.com/camelone2011/
> Twitter: davsclaus
> Blog: http://davsclaus.blogspot.com/
> Author of Camel in Action: http://www.manning.com/ibsen/
>
>
>
>
>
>
>
> InterComponentWare AG:
> Vorstand: Peter Kirschbauer (Vors.), Jörg Stadler
> Aufsichtsratsvors.: Prof. Dr. Christof Hettich
> Firmensitz: 69190 Walldorf, Altrottstraße 31
> AG Mannheim HRB 351761 / USt.-IdNr.: DE 198388516



-- 
Claus Ibsen
-----------------
FuseSource
Email: cibsen@fusesource.com
Web: http://fusesource.com
CamelOne 2011: http://fusesource.com/camelone2011/
Twitter: davsclaus
Blog: http://davsclaus.blogspot.com/
Author of Camel in Action: http://www.manning.com/ibsen/

Re: Consumer and Producer names in JMX

Posted by mi...@icw.de.
Hi Claus, 

It's about the name that is shown in the JMX tree uner 
org.apache.camel/consumers/context/consumerName (see the code snppet)

There is an endpoint uri attribute in the jmx objects, but it does not 
help navigate. One has to expand the jmx Consumer/Producer objects to find 
to which endpoint they belong. 

Regards, 
Mitko




From:
Claus Ibsen <cl...@gmail.com>
To:
dev@camel.apache.org
Date:
27.04.2011 16:17
Subject:
Re: Consumer and Producer names in JMX



They have an endpoint uri attribute.


On Wed, Apr 27, 2011 at 4:11 PM,  <mi...@icw.de> wrote:
> Hello Camel devs,
>
> Currently the consumer and producer names in JMX have a name based on
> their java instance [1]. Due to this it is not obvious what is the
> endpoint  of the consumers/producers.
>
> Would not it be better to use name based on endpoint URI of the
> consumer/producer endpoints (combined with identityHashcode) instead?
>
>
> [1] Copy/paste from the DefaultManagementNamingStrategy
>
> ...
>   String name = consumer.getClass().getSimpleName();
>        if (ObjectHelper.isEmpty(name)) {
>            name = "Consumer";
>        }
>        buffer.append(KEY_NAME + "=")
>            .append(name)
>            .append("(").append(ObjectHelper.getIdentityHashCode
> (consumer)).append(")");
>
> ...
>
> Regards,
> Mitko
>
>
>
>
> InterComponentWare AG:
> Vorstand: Peter Kirschbauer (Vors.), Jörg Stadler
> Aufsichtsratsvors.: Prof. Dr. Christof Hettich
> Firmensitz: 69190 Walldorf, Altrottstraße 31
> AG Mannheim HRB 351761 / USt.-IdNr.: DE 198388516



-- 
Claus Ibsen
-----------------
FuseSource
Email: cibsen@fusesource.com
Web: http://fusesource.com
CamelOne 2011: http://fusesource.com/camelone2011/
Twitter: davsclaus
Blog: http://davsclaus.blogspot.com/
Author of Camel in Action: http://www.manning.com/ibsen/





   

InterComponentWare AG:  
Vorstand: Peter Kirschbauer (Vors.), Jörg Stadler  
Aufsichtsratsvors.: Prof. Dr. Christof Hettich  
Firmensitz: 69190 Walldorf, Altrottstraße 31  
AG Mannheim HRB 351761 / USt.-IdNr.: DE 198388516  

Re: Consumer and Producer names in JMX

Posted by Claus Ibsen <cl...@gmail.com>.
They have an endpoint uri attribute.


On Wed, Apr 27, 2011 at 4:11 PM,  <mi...@icw.de> wrote:
> Hello Camel devs,
>
> Currently the consumer and producer names in JMX have a name based on
> their java instance [1]. Due to this it is not obvious what is the
> endpoint  of the consumers/producers.
>
> Would not it be better to use name based on endpoint URI of the
> consumer/producer endpoints (combined with identityHashcode) instead?
>
>
> [1] Copy/paste from the DefaultManagementNamingStrategy
>
> ...
>   String name = consumer.getClass().getSimpleName();
>        if (ObjectHelper.isEmpty(name)) {
>            name = "Consumer";
>        }
>        buffer.append(KEY_NAME + "=")
>            .append(name)
>            .append("(").append(ObjectHelper.getIdentityHashCode
> (consumer)).append(")");
>
> ...
>
> Regards,
> Mitko
>
>
>
>
> InterComponentWare AG:
> Vorstand: Peter Kirschbauer (Vors.), Jörg Stadler
> Aufsichtsratsvors.: Prof. Dr. Christof Hettich
> Firmensitz: 69190 Walldorf, Altrottstraße 31
> AG Mannheim HRB 351761 / USt.-IdNr.: DE 198388516



-- 
Claus Ibsen
-----------------
FuseSource
Email: cibsen@fusesource.com
Web: http://fusesource.com
CamelOne 2011: http://fusesource.com/camelone2011/
Twitter: davsclaus
Blog: http://davsclaus.blogspot.com/
Author of Camel in Action: http://www.manning.com/ibsen/