You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/10/31 23:34:00 UTC
[jira] [Commented] (GEODE-5881) consolidate DefaultQuery.TestHook
methods
[ https://issues.apache.org/jira/browse/GEODE-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670896#comment-16670896 ]
ASF subversion and git services commented on GEODE-5881:
--------------------------------------------------------
Commit b040508b61839467e9bb737e1780920d4d2fe5c1 in geode's branch refs/heads/develop from [~propeller]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=b040508 ]
GEODE-5881: simplify DefaultQuery.TestHook (#2755)
Consolidate three interface methods into one that takes an enum
to identify the "spot" in the query processing logic.
Co-authored-by: Bill Burcham <bb...@pivotal.io>
Co-authored-by: Dale Emery <de...@pivotal.io>
Co-authored-by: Galen O'Sullivan <go...@pivotal.io>
> consolidate DefaultQuery.TestHook methods
> -----------------------------------------
>
> Key: GEODE-5881
> URL: https://issues.apache.org/jira/browse/GEODE-5881
> Project: Geode
> Issue Type: Task
> Components: querying
> Reporter: Bill
> Assignee: Bill
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.8.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> {{DefaultQuery.TestHook}} (interface) defines three methods. They all take a "spot" identifier. But some take an {{int}} as the identifier and others take a {{String}}.
> When this task is complete, all the methods will use an {{enum}} to identify the spot. The benefit will be that we'll have more readable identifiers (than the ints) and we'll be able to {{switch}} on the spot id instead of using conditionals and {{equals()}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)