You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/03/20 18:36:37 UTC
Review Request 66178: Added a test to verify that task launch order is
enforced.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66178/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao and Greg Mann.
Bugs: MESOS-8617 and MESOS-8624
https://issues.apache.org/jira/browse/MESOS-8617
https://issues.apache.org/jira/browse/MESOS-8624
Repository: mesos
Description
-------
Agent should launch the task in their receiving order.
On the task launch path, there are currently two
asynchronous steps which may complete out of order:
unschedule GC and task authorization.
This test simulates the reordering of the completions
of task authorization step and verify that, despite the
reordering, tasks can still launch in their original order.
Diffs
-----
src/tests/mesos.hpp 2c3d0c9350bbbbcd2223ff20c0797d1849d38c19
src/tests/mesos.cpp d82963195573dd9ed7d12a7708f64a236b28cdf1
src/tests/slave_tests.cpp f76500ebdb67f131a57a3b5aaae8c952d019e354
Diff: https://reviews.apache.org/r/66178/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 66178: Added a test to verify that task launch
order is enforced.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66178/
-----------------------------------------------------------
(Updated April 5, 2018, 5:35 p.m.)
Review request for mesos, Chun-Hung Hsiao and Greg Mann.
Changes
-------
set expectations in the right order.
Bugs: MESOS-8617 and MESOS-8624
https://issues.apache.org/jira/browse/MESOS-8617
https://issues.apache.org/jira/browse/MESOS-8624
Repository: mesos
Description
-------
Agent should launch the task in their receiving order.
On the task launch path, there are currently two
asynchronous steps which may complete out of order:
unschedule GC and task authorization.
This test simulates the reordering of the completions
of task authorization step and verify that, despite the
reordering, tasks can still launch in their original order.
Diffs (updated)
-----
src/tests/mesos.hpp 46c271b5c5bedbdabd58b3cdbb82216d55c846bd
src/tests/mesos.cpp d82963195573dd9ed7d12a7708f64a236b28cdf1
src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
Diff: https://reviews.apache.org/r/66178/diff/7/
Changes: https://reviews.apache.org/r/66178/diff/6-7/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 66178: Added a test to verify that task launch
order is enforced.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66178/#review200526
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On April 4, 2018, 3:24 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66178/
> -----------------------------------------------------------
>
> (Updated April 4, 2018, 3:24 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
>
>
> Bugs: MESOS-8617 and MESOS-8624
> https://issues.apache.org/jira/browse/MESOS-8617
> https://issues.apache.org/jira/browse/MESOS-8624
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Agent should launch the task in their receiving order.
> On the task launch path, there are currently two
> asynchronous steps which may complete out of order:
> unschedule GC and task authorization.
>
> This test simulates the reordering of the completions
> of task authorization step and verify that, despite the
> reordering, tasks can still launch in their original order.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 46c271b5c5bedbdabd58b3cdbb82216d55c846bd
> src/tests/mesos.cpp d82963195573dd9ed7d12a7708f64a236b28cdf1
> src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
>
>
> Diff: https://reviews.apache.org/r/66178/diff/5/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66178: Added a test to verify that task launch
order is enforced.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66178/
-----------------------------------------------------------
(Updated April 3, 2018, 8:24 p.m.)
Review request for mesos, Chun-Hung Hsiao and Greg Mann.
Changes
-------
Updated the test to use a matcher for a more robust test run.
Bugs: MESOS-8617 and MESOS-8624
https://issues.apache.org/jira/browse/MESOS-8617
https://issues.apache.org/jira/browse/MESOS-8624
Repository: mesos
Description
-------
Agent should launch the task in their receiving order.
On the task launch path, there are currently two
asynchronous steps which may complete out of order:
unschedule GC and task authorization.
This test simulates the reordering of the completions
of task authorization step and verify that, despite the
reordering, tasks can still launch in their original order.
Diffs (updated)
-----
src/tests/mesos.hpp 46c271b5c5bedbdabd58b3cdbb82216d55c846bd
src/tests/mesos.cpp d82963195573dd9ed7d12a7708f64a236b28cdf1
src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
Diff: https://reviews.apache.org/r/66178/diff/4/
Changes: https://reviews.apache.org/r/66178/diff/3-4/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 66178: Added a test to verify that task launch
order is enforced.
Posted by Meng Zhu <mz...@mesosphere.io>.
> On April 3, 2018, 10:51 a.m., Greg Mann wrote:
> > src/tests/slave_tests.cpp
> > Lines 5114 (patched)
> > <https://reviews.apache.org/r/66178/diff/2/?file=1984774#file1984774line5114>
> >
> > Is this necessary?
To avoid uninteresing mock call.
> On April 3, 2018, 10:51 a.m., Greg Mann wrote:
> > src/tests/slave_tests.cpp
> > Lines 5181-5182 (patched)
> > <https://reviews.apache.org/r/66178/diff/2/?file=1984774#file1984774line5181>
> >
> > Should we assert here that task 2 has not launched yet?
Good point.
- Meng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66178/#review200381
-----------------------------------------------------------
On March 21, 2018, 2:58 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66178/
> -----------------------------------------------------------
>
> (Updated March 21, 2018, 2:58 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
>
>
> Bugs: MESOS-8617 and MESOS-8624
> https://issues.apache.org/jira/browse/MESOS-8617
> https://issues.apache.org/jira/browse/MESOS-8624
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Agent should launch the task in their receiving order.
> On the task launch path, there are currently two
> asynchronous steps which may complete out of order:
> unschedule GC and task authorization.
>
> This test simulates the reordering of the completions
> of task authorization step and verify that, despite the
> reordering, tasks can still launch in their original order.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 46c271b5c5bedbdabd58b3cdbb82216d55c846bd
> src/tests/mesos.cpp d82963195573dd9ed7d12a7708f64a236b28cdf1
> src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
>
>
> Diff: https://reviews.apache.org/r/66178/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66178: Added a test to verify that task launch
order is enforced.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66178/#review200381
-----------------------------------------------------------
src/tests/slave_tests.cpp
Lines 5070 (patched)
<https://reviews.apache.org/r/66178/#comment281097>
s/runTask(Group)Message/RunTask(Group)Message/
src/tests/slave_tests.cpp
Lines 5073 (patched)
<https://reviews.apache.org/r/66178/#comment281100>
I would recommend the name `LaunchTasksReorderTaskAuthorization`.
src/tests/slave_tests.cpp
Lines 5081 (patched)
<https://reviews.apache.org/r/66178/#comment281102>
Ditto here - move this down a bit.
src/tests/slave_tests.cpp
Lines 5083-5088 (patched)
<https://reviews.apache.org/r/66178/#comment281101>
Ditto on consistent newlines here.
src/tests/slave_tests.cpp
Lines 5114 (patched)
<https://reviews.apache.org/r/66178/#comment281103>
Is this necessary?
src/tests/slave_tests.cpp
Lines 5176-5177 (patched)
<https://reviews.apache.org/r/66178/#comment281104>
Need a period at the end of this comment.
src/tests/slave_tests.cpp
Lines 5180 (patched)
<https://reviews.apache.org/r/66178/#comment281105>
Nit: enclose `taskGroup2` in backticks, here and elsewhere.
src/tests/slave_tests.cpp
Lines 5181-5182 (patched)
<https://reviews.apache.org/r/66178/#comment281106>
Should we assert here that task 2 has not launched yet?
src/tests/slave_tests.cpp
Lines 5186 (patched)
<https://reviews.apache.org/r/66178/#comment281107>
s/subseuqently/subsequently/
- Greg Mann
On March 21, 2018, 9:58 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66178/
> -----------------------------------------------------------
>
> (Updated March 21, 2018, 9:58 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
>
>
> Bugs: MESOS-8617 and MESOS-8624
> https://issues.apache.org/jira/browse/MESOS-8617
> https://issues.apache.org/jira/browse/MESOS-8624
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Agent should launch the task in their receiving order.
> On the task launch path, there are currently two
> asynchronous steps which may complete out of order:
> unschedule GC and task authorization.
>
> This test simulates the reordering of the completions
> of task authorization step and verify that, despite the
> reordering, tasks can still launch in their original order.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 2c3d0c9350bbbbcd2223ff20c0797d1849d38c19
> src/tests/mesos.cpp d82963195573dd9ed7d12a7708f64a236b28cdf1
> src/tests/slave_tests.cpp f76500ebdb67f131a57a3b5aaae8c952d019e354
>
>
> Diff: https://reviews.apache.org/r/66178/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66178: Added a test to verify that task launch
order is enforced.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66178/#review199726
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66118', '66119', '66120', '65679', '66126', '66143', '66144', '66145', '66178']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66178
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66178/logs/mesos-tests-stdout.log):
```
[----------] 9 tests from Endpoint/SlaveEndpointTest (1042 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (37 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (38 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (77 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (820 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (849 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (837 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (865 ms total)
[----------] Global test environment tear-down
[==========] 936 tests from 92 test cases ran. (913303 ms total)
[ PASSED ] 934 tests.
[ FAILED ] 2 tests, listed below:
[ FAILED ] DockerContainerizerHealthCheckTest.ROOT_DOCKER_DockerHealthyTask
[ FAILED ] DockerContainerizerHealthCheckTest.ROOT_DOCKER_DockerHealthyTaskWithQuotedCommand
2 FAILED TESTS
YOU HAVE 215 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66178/logs/mesos-tests-stderr.log):
```
I0321 23:46:32.039214 8476 master.cpp:10248] Updating the state of task 996b5a45-f274-4bd2-835a-89493867eede of framework 6beea5d7-6262-4008-8a3c-439346362782-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0321 23:46:32.039214 7628 slave.cpp:3871] Shutting down framework 6beea5d7-6262-4008-8a3c-439346362782-0000
I0321 23:46:32.039214 7628 slave.cpp:6564] Shutting down executor '996b5a45-f274-4bd2-835a-89493867eede' of framework 6beea5d7-6262-4008-8a3c-4393463627I0321 23:46:31.840212 3196 exec.cpp:162] Version: 1.6.0
I0321 23:46:31.869184 6760 exec.cpp:236] Executor registered on agent 6beea5d7-6262-4008-8a3c-439346362782-S0
I0321 23:46:31.873210 3108 executor.cpp:176] Received SUBSCRIBED event
I0321 23:46:31.878209 3108 executor.cpp:180] Subscribed executor on win-bld-srv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0321 23:46:31.878209 3108 executor.cpp:176] Received LAUNCH event
I0321 23:46:31.883210 3108 executor.cpp:648] Starting task 996b5a45-f274-4bd2-835a-89493867eede
I0321 23:46:31.976214 3108 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0321 23:46:32.006216 3108 executor.cpp:661] Forked command at 14080
I0321 23:46:32.042184 12368 exec.cpp:445] Executor asked to shutdown
I0321 23:46:32.042184 14744 executor.cpp:176] Received SHUTDOWN event
I0321 23:46:32.042184 14744 executor.cpp:758] Shutting down
I0321 23:46:32.042184 14744 executor.cpp:868] Sending SIGTERM to process tree at pi82-0000 at executor(1)@10.3.1.8:63066
I0321 23:46:32.041184 7628 slave.cpp:919] Agent terminating
W0321 23:46:32.041184 7628 slave.cpp:3867] Ignoring shutdown framework 6beea5d7-6262-4008-8a3c-439346362782-0000 because it is terminating
I0321 23:46:32.041184 8476 master.cpp:10347] Removing task 996b5a45-f274-4bd2-835a-89493867eede with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 6beea5d7-6262-4008-8a3c-439346362782-0000 on agent 6beea5d7-6262-4008-8a3c-439346362782-S0 at slave(407)@10.3.1.8:61203 (win-bld-srv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0321 23:46:32.044185 8476 master.cpp:1295] Agent 6beea5d7-6262-4008-8a3c-439346362782-S0 at slave(407)@10.3.1.8:61203 (win-bld-srv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0321 23:46:32.044185 8476 master.cpp:3276] Disconnecting agent 6beea5d7-6262-4008-8a3c-439346362782-S0 at slave(407)@10.3.1.8:61203 (win-bld-srv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0321 23:46:32.044185 2228 hierarchical.cpp:344] Removed framework 6beea5d7-6262-4008-8a3c-439346362782-0000
I0321 23:46:32.044185 8476 master.cpp:3295] Deactivating agent 6beea5d7-6262-4008-8a3c-439346362782-S0 at slave(407)@10.3.1.8:61203 (win-bld-srv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0321 23:46:32.045182 10244 containerizer.cpp:2338] Destroying container 6f725142-b559-44e2-89cb-25ed9bd92570 in RUNNING state
I0321 23:46:32.045182 10244 containerizer.cpp:2952] Transitioning the state of container 6f725142-b559-44e2-89cb-25ed9bd92570 from RUNNING to DESTROYING
I0321 23:46:32.045182 7628 hierarchical.cpp:766] Agent 6beea5d7-6262-4008-8a3c-439346362782-S0 deactivated
I0321 23:46:32.047181 10244 launcher.cpp:156] Asked to destroy container 6f725142-b559-44e2-89cb-25ed9bd92570
I0321 23:46:32.141197 14676 containerizer.cpp:2791] Container 6f725142-b559-44e2-89cb-25ed9bd92570 has exited
I0321 23:46:32.173188 11080 master.cpp:1137] Master terminating
I0321 23:46:32.175199 2228 hierarchical.cpp:609] Removed agent 6beea5d7-6262-4008-8a3c-439346362782-S0
I0321 23:46:32.753221 12712 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 21, 2018, 2:58 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66178/
> -----------------------------------------------------------
>
> (Updated March 21, 2018, 2:58 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
>
>
> Bugs: MESOS-8617 and MESOS-8624
> https://issues.apache.org/jira/browse/MESOS-8617
> https://issues.apache.org/jira/browse/MESOS-8624
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Agent should launch the task in their receiving order.
> On the task launch path, there are currently two
> asynchronous steps which may complete out of order:
> unschedule GC and task authorization.
>
> This test simulates the reordering of the completions
> of task authorization step and verify that, despite the
> reordering, tasks can still launch in their original order.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 2c3d0c9350bbbbcd2223ff20c0797d1849d38c19
> src/tests/mesos.cpp d82963195573dd9ed7d12a7708f64a236b28cdf1
> src/tests/slave_tests.cpp f76500ebdb67f131a57a3b5aaae8c952d019e354
>
>
> Diff: https://reviews.apache.org/r/66178/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66178: Added a test to verify that task launch
order is enforced.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66178/#review199736
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66118, 66119, 66120, 65679, 66126, 66143, 66144, 66145, 66178]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 21, 2018, 9:58 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66178/
> -----------------------------------------------------------
>
> (Updated March 21, 2018, 9:58 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
>
>
> Bugs: MESOS-8617 and MESOS-8624
> https://issues.apache.org/jira/browse/MESOS-8617
> https://issues.apache.org/jira/browse/MESOS-8624
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Agent should launch the task in their receiving order.
> On the task launch path, there are currently two
> asynchronous steps which may complete out of order:
> unschedule GC and task authorization.
>
> This test simulates the reordering of the completions
> of task authorization step and verify that, despite the
> reordering, tasks can still launch in their original order.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 2c3d0c9350bbbbcd2223ff20c0797d1849d38c19
> src/tests/mesos.cpp d82963195573dd9ed7d12a7708f64a236b28cdf1
> src/tests/slave_tests.cpp f76500ebdb67f131a57a3b5aaae8c952d019e354
>
>
> Diff: https://reviews.apache.org/r/66178/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66178: Added a test to verify that task launch
order is enforced.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66178/
-----------------------------------------------------------
(Updated March 21, 2018, 2:58 p.m.)
Review request for mesos, Chun-Hung Hsiao and Greg Mann.
Changes
-------
Thanks for the review! Patch updated.
Bugs: MESOS-8617 and MESOS-8624
https://issues.apache.org/jira/browse/MESOS-8617
https://issues.apache.org/jira/browse/MESOS-8624
Repository: mesos
Description
-------
Agent should launch the task in their receiving order.
On the task launch path, there are currently two
asynchronous steps which may complete out of order:
unschedule GC and task authorization.
This test simulates the reordering of the completions
of task authorization step and verify that, despite the
reordering, tasks can still launch in their original order.
Diffs (updated)
-----
src/tests/mesos.hpp 2c3d0c9350bbbbcd2223ff20c0797d1849d38c19
src/tests/mesos.cpp d82963195573dd9ed7d12a7708f64a236b28cdf1
src/tests/slave_tests.cpp f76500ebdb67f131a57a3b5aaae8c952d019e354
Diff: https://reviews.apache.org/r/66178/diff/2/
Changes: https://reviews.apache.org/r/66178/diff/1-2/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 66178: Added a test to verify that task launch
order is enforced.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66178/#review199591
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66118', '66119', '66120', '65679', '66126', '66143', '66144', '66145', '66178']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66178
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66178/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (109 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1043 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (36 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (41 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (79 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (834 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (865 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (841 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (871 ms total)
[----------] Global test environment tear-down
[==========] 936 tests from 92 test cases ran. (679359 ms total)
[ PASSED ] 935 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerContainerizerHealthCheckTest.ROOT_DOCKER_DockerHealthyTaskWithQuotedCommand
1 FAILED TEST
YOU HAVE 215 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66178/logs/mesos-tests-stderr.log):
```
I0320 21:56:40.184705 6296 master.cpp:10255] Updating the state of task cdc91fd7-3a79-4bd9-a20f-61faccf4d5bc of framework 8fdf3455-3590-4df0-82ea-570c7d49b567-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0320 21:56:40.185685 8136 slave.cpp:3876] Shutting down framework 8fdf3455-3590-4df0-82ea-570c7d49b567-0000
I0320 21:56:40.185685 8136 slave.cpp:6569] Shutting down executor 'cdc91fd7-3a79-4bd9-a20f-61faccf4d5bc' of framework 8fdf3455-3590-4df0-82ea-570c7d49b567-0000 at executor(1)@10.3.1.8:64467
I0320 21:56:40.186676 8136 slave.cpp:925] Agent terminating
W0320 21:56:40.186676 8136 slave.cpp:3872] IgnoriI0320 21:56:39.990691 11924 exec.cpp:162] Version: 1.6.0
I0320 21:56:40.018695 9788 exec.cpp:236] Executor registered on agent 8fdf3455-3590-4df0-82ea-570c7d49b567-S0
I0320 21:56:40.023653 8572 executor.cpp:176] Received SUBSCRIBED event
I0320 21:56:40.027721 8572 executor.cpp:180] Subscribed executor on win-bld-srv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0320 21:56:40.028713 8572 executor.cpp:176] Received LAUNCH event
I0320 21:56:40.033659 8572 executor.cpp:648] Starting task cdc91fd7-3a79-4bd9-a20f-61faccf4d5bc
I0320 21:56:40.113693 8572 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0320 21:56:40.147699 8572 executor.cpp:661] Forked command at 948
I0320 21:56:40.187680 14164 exec.cpp:445] Executor asked to shutdown
I0320 21:56:40.187680 10120 executor.cpp:176] Received SHUTDOWN event
I0320 21:56:40.187680 10120 executor.cpp:758] Shutting down
I0320 21:56:40.188678 10120 executor.cpp:868] Sending SIGTERM to process tree at pid ng shutdown framework 8fdf3455-3590-4df0-82ea-570c7d49b567-0000 because it is terminating
I0320 21:56:40.187680 6296 master.cpp:10354] Removing task cdc91fd7-3a79-4bd9-a20f-61faccf4d5bc with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 8fdf3455-3590-4df0-82ea-570c7d49b567-0000 on agent 8fdf3455-3590-4df0-82ea-570c7d49b567-S0 at slave(407)@10.3.1.8:62597 (win-bld-srv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0320 21:56:40.189673 6296 master.cpp:1297] Agent 8fdf3455-3590-4df0-82ea-570c7d49b567-S0 at slave(407)@10.3.1.8:62597 (win-bld-srv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0320 21:56:40.189673 6296 master.cpp:3278] Disconnecting agent 8fdf3455-3590-4df0-82ea-570c7d49b567-S0 at slave(407)@10.3.1.8:62597 (win-bld-srv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0320 21:56:40.189673 6296 master.cpp:3297] Deactivating agent 8fdf3455-3590-4df0-82ea-570c7d49b567-S0 at slave(407)@10.3.1.8:62597 (win-bld-srv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0320 21:56:40.190672 6864 containerizer.cpp:2338] Destroying container ce67c839-675c-417b-a2d0-e9b94890b047 in RUNNING state
I0320 21:56:40.190672 2412 hierarchical.cpp:344] Removed framework 8fdf3455-3590-4df0-82ea-570c7d49b567-0000
I0320 21:56:40.190672 6864 containerizer.cpp:2952] Transitioning the state of container ce67c839-675c-417b-a2d0-e9b94890b047 from RUNNING to DESTROYING
I0320 21:56:40.190672 2412 hierarchical.cpp:766] Agent 8fdf3455-3590-4df0-82ea-570c7d49b567-S0 deactivated
I0320 21:56:40.191685 6864 launcher.cpp:156] Asked to destroy container ce67c839-675c-417b-a2d0-e9b94890b047
I0320 21:56:40.249722 12720 containerizer.cpp:2791] Container ce67c839-675c-417b-a2d0-e9b94890b047 has exited
I0320 21:56:40.282680 12260 master.cpp:1139] Master terminating
I0320 21:56:40.284689 8136 hierarchical.cpp:609] Removed agent 8fdf3455-3590-4df0-82ea-570c7d49b567-S0
I0320 21:56:41.246773 13200 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 20, 2018, 6:36 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66178/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 6:36 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
>
>
> Bugs: MESOS-8617 and MESOS-8624
> https://issues.apache.org/jira/browse/MESOS-8617
> https://issues.apache.org/jira/browse/MESOS-8624
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Agent should launch the task in their receiving order.
> On the task launch path, there are currently two
> asynchronous steps which may complete out of order:
> unschedule GC and task authorization.
>
> This test simulates the reordering of the completions
> of task authorization step and verify that, despite the
> reordering, tasks can still launch in their original order.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 2c3d0c9350bbbbcd2223ff20c0797d1849d38c19
> src/tests/mesos.cpp d82963195573dd9ed7d12a7708f64a236b28cdf1
> src/tests/slave_tests.cpp f76500ebdb67f131a57a3b5aaae8c952d019e354
>
>
> Diff: https://reviews.apache.org/r/66178/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66178: Added a test to verify that task launch
order is enforced.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66178/#review199691
-----------------------------------------------------------
src/tests/slave_tests.cpp
Line 5088 (original), 5088 (patched)
<https://reviews.apache.org/r/66178/#comment280083>
See comments in the parent patch, which also apply here.
- Greg Mann
On March 20, 2018, 6:36 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66178/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 6:36 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
>
>
> Bugs: MESOS-8617 and MESOS-8624
> https://issues.apache.org/jira/browse/MESOS-8617
> https://issues.apache.org/jira/browse/MESOS-8624
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Agent should launch the task in their receiving order.
> On the task launch path, there are currently two
> asynchronous steps which may complete out of order:
> unschedule GC and task authorization.
>
> This test simulates the reordering of the completions
> of task authorization step and verify that, despite the
> reordering, tasks can still launch in their original order.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 2c3d0c9350bbbbcd2223ff20c0797d1849d38c19
> src/tests/mesos.cpp d82963195573dd9ed7d12a7708f64a236b28cdf1
> src/tests/slave_tests.cpp f76500ebdb67f131a57a3b5aaae8c952d019e354
>
>
> Diff: https://reviews.apache.org/r/66178/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66178: Added a test to verify that task launch
order is enforced.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66178/#review199594
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66118, 66119, 66120, 65679, 66126, 66143, 66144, 66145, 66178]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 20, 2018, 6:36 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66178/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 6:36 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
>
>
> Bugs: MESOS-8617 and MESOS-8624
> https://issues.apache.org/jira/browse/MESOS-8617
> https://issues.apache.org/jira/browse/MESOS-8624
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Agent should launch the task in their receiving order.
> On the task launch path, there are currently two
> asynchronous steps which may complete out of order:
> unschedule GC and task authorization.
>
> This test simulates the reordering of the completions
> of task authorization step and verify that, despite the
> reordering, tasks can still launch in their original order.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 2c3d0c9350bbbbcd2223ff20c0797d1849d38c19
> src/tests/mesos.cpp d82963195573dd9ed7d12a7708f64a236b28cdf1
> src/tests/slave_tests.cpp f76500ebdb67f131a57a3b5aaae8c952d019e354
>
>
> Diff: https://reviews.apache.org/r/66178/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>