You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/02 22:55:58 UTC

[GitHub] [beam] aaltay commented on a change in pull request #11269: [BEAM-9199] Require Dataflow --region in Python SDK.

aaltay commented on a change in pull request #11269: [BEAM-9199] Require Dataflow --region in Python SDK.
URL: https://github.com/apache/beam/pull/11269#discussion_r402642552
 
 

 ##########
 File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
 ##########
 @@ -1396,6 +1399,36 @@ def json_string_to_byte_array(encoded_string):
     """Implements org.apache.beam.sdk.util.StringUtils.jsonStringToByteArray."""
     return unquote_to_bytes(encoded_string)
 
+  def get_default_gcp_region(self):
 
 Review comment:
   Do we test this method? (Tests all seemingly overwrite it.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services