You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Ma77Ball (via GitHub)" <gi...@apache.org> on 2026/05/09 08:21:26 UTC

[PR] fix: don't re-throw in jsdom-svg-polyfill uncaughtException handler [texera]

Ma77Ball opened a new pull request, #4999:
URL: https://github.com/apache/texera/pull/4999

   
   ### What changes were proposed in this PR?
     Replace the `throw err` / `throw reason` inside the `process.on("uncaughtException")` and `process.on("unhandledRejection")` handlers in `frontend/src/jsdom-svg-polyfill.ts` with `console.error(...)`.
     
     Re-throwing in `uncaughtException` aborts the Node process, crashing the Vitest worker mid-run and leaving the runner hanging until the CI timeout. Logging instead lets Vitest's own error handling fail the offending spec
     without killing sibling tests in the same worker.
   
   ### Any related issues, documentation, or discussions?
   Closes: #4998
   ### How was this PR tested?
     Ran `yarn ng test --watch=false` locally — full suite passes cleanly. CI runs on the branch that no longer hangs.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   Discovered with Claude Opus 4.7 in compliance with ASF


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: don't re-throw in jsdom-svg-polyfill uncaughtException handler [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #4999:
URL: https://github.com/apache/texera/pull/4999


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: don't re-throw in jsdom-svg-polyfill uncaughtException handler [texera]

Posted by "Ma77Ball (via GitHub)" <gi...@apache.org>.
Ma77Ball commented on PR #4999:
URL: https://github.com/apache/texera/pull/4999#issuecomment-4412027157

   Currently doing testing at:
   - Control: https://github.com/Ma77Ball/texera/actions/runs/25596303738/job/75142737177?pr=52
   - Test/Fix: https://github.com/Ma77Ball/texera/actions/runs/25596303738/job/75142737194?pr=52 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: don't re-throw in jsdom-svg-polyfill uncaughtException handler [texera]

Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #4999:
URL: https://github.com/apache/texera/pull/4999#issuecomment-4413711685

   Thanks for the fix!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: don't re-throw in jsdom-svg-polyfill uncaughtException handler [texera]

Posted by "Ma77Ball (via GitHub)" <gi...@apache.org>.
Ma77Ball commented on PR #4999:
URL: https://github.com/apache/texera/pull/4999#issuecomment-4412043582

   After running the frontend test 3 times, I found the control got caught on the same error while the test/fix experienced no errors. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: don't re-throw in jsdom-svg-polyfill uncaughtException handler [texera]

Posted by "Ma77Ball (via GitHub)" <gi...@apache.org>.
Ma77Ball commented on PR #4999:
URL: https://github.com/apache/texera/pull/4999#issuecomment-4412044399

   /request-review @aglinxinyuan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: don't re-throw in jsdom-svg-polyfill uncaughtException handler [texera]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4999:
URL: https://github.com/apache/texera/pull/4999#issuecomment-4412056612

   ## [Codecov](https://app.codecov.io/gh/apache/texera/pull/4999?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 42.72%. Comparing base ([`75ff07e`](https://app.codecov.io/gh/apache/texera/commit/75ff07e36adcc626a91a41f96b78893e2d5e63c3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`37742cd`](https://app.codecov.io/gh/apache/texera/commit/37742cdd2283c0341f82d588b20bf0bc505a0f16?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff            @@
   ##               main    #4999   +/-   ##
   =========================================
     Coverage     42.72%   42.72%           
     Complexity     2186     2186           
   =========================================
     Files          1031     1031           
     Lines         38152    38152           
     Branches       4004     4004           
   =========================================
     Hits          16302    16302           
     Misses        20831    20831           
     Partials       1019     1019           
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/texera/pull/4999/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
   |---|---|---|---|
   | [access-control-service](https://app.codecov.io/gh/apache/texera/pull/4999/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.53% <ø> (ø)` | | Carriedforward from [75ff07e](https://app.codecov.io/gh/apache/texera/commit/75ff07e36adcc626a91a41f96b78893e2d5e63c3?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [agent-service](https://app.codecov.io/gh/apache/texera/pull/4999/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.72% <ø> (ø)` | | Carriedforward from [75ff07e](https://app.codecov.io/gh/apache/texera/commit/75ff07e36adcc626a91a41f96b78893e2d5e63c3?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [amber](https://app.codecov.io/gh/apache/texera/pull/4999/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.22% <ø> (ø)` | | Carriedforward from [75ff07e](https://app.codecov.io/gh/apache/texera/commit/75ff07e36adcc626a91a41f96b78893e2d5e63c3?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/4999/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [75ff07e](https://app.codecov.io/gh/apache/texera/commit/75ff07e36adcc626a91a41f96b78893e2d5e63c3?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [config-service](https://app.codecov.io/gh/apache/texera/pull/4999/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [75ff07e](https://app.codecov.io/gh/apache/texera/commit/75ff07e36adcc626a91a41f96b78893e2d5e63c3?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [file-service](https://app.codecov.io/gh/apache/texera/pull/4999/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.18% <ø> (ø)` | | Carriedforward from [75ff07e](https://app.codecov.io/gh/apache/texera/commit/75ff07e36adcc626a91a41f96b78893e2d5e63c3?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [frontend](https://app.codecov.io/gh/apache/texera/pull/4999/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.08% <ø> (ø)` | | |
   | [python](https://app.codecov.io/gh/apache/texera/pull/4999/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `88.90% <ø> (ø)` | | Carriedforward from [75ff07e](https://app.codecov.io/gh/apache/texera/commit/75ff07e36adcc626a91a41f96b78893e2d5e63c3?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/4999/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.72% <ø> (ø)` | | Carriedforward from [75ff07e](https://app.codecov.io/gh/apache/texera/commit/75ff07e36adcc626a91a41f96b78893e2d5e63c3?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/texera/pull/4999?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org