You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2021/09/15 10:18:30 UTC
[GitHub] [drill] dzamo opened a new pull request #2317: Base Docker image on maven:3.8.2-jdk-11 and openjdk-11.
dzamo opened a new pull request #2317:
URL: https://github.com/apache/drill/pull/2317
# [DRILL-7999](https://issues.apache.org/jira/browse/DRILL-7999): Base Docker image on maven:3.8.2-jdk-11 and openjdk-11
## Description
Our Docker container builds on OpenJDK 8u232 (released late in 2019), while the current LTS series of OpenJDK is 11. Update our Dockerfile to OpenJDK 11.
## Documentation
Unchanged except that I do address the following docs issues pointed out by a user, not related to this JDK version change.
> 1. Drill documentation referrs to $DRILL_HOME environment variable which is not set in the Docker Image. Additionally in the doucmenation says it can be found in /etc/drill/conf while in the Docker image Drill has been installed into /opt/drill/conf
> 2. Add information how to add (mount) custom configuration files into the Docker image or even better, just make sure there is a Docker section in Drill's documentation whereever appropriate
## Testing
- Test Drill built from master branch (1.20-SNAPSHOT) with OpenJDK 11 outside of Docker.
- Test Drill built from master branch (1.20-SNAPSHOT) with OpenJDK 11 inside of Docker by building a Docker image from the updated Dockerfile.
- Test a downloaded build of Drill 1.19 inside a Docker container based on OpenJDK 11 (published [here](https://hub.docker.com/repository/docker/dzamo2/drill)).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] luocooong commented on pull request #2317: Base Docker image on maven:3.8.2-jdk-11 and openjdk-11.
Posted by GitBox <gi...@apache.org>.
luocooong commented on pull request #2317:
URL: https://github.com/apache/drill/pull/2317#issuecomment-920458170
@dzamo If possible, rebase the code on the master. It included a Travis CI bugfix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] dzamo commented on a change in pull request #2317: DRILL-7999 Base Docker image on maven:3.8.2-jdk-11 and openjdk-11
Posted by GitBox <gi...@apache.org>.
dzamo commented on a change in pull request #2317:
URL: https://github.com/apache/drill/pull/2317#discussion_r710087396
##########
File path: Dockerfile
##########
@@ -16,31 +16,53 @@
# limitations under the License.
#
-# This Dockerfile is used for automated builds in DockerHub. It adds project sources into the build image, builds
-# Drill and copies built binaries into the target image based on openjdk:8u232-jdk image.
+# This Dockerfile is used for automated builds in DockerHub. It adds
+# project sources into the build image, builds Drill and copies built
+# binaries into the target image based on the image name in BASE_NAME
+# env var which you should set when invoking docker build.
+# Example BASE_NAME values: openjdk:8-jre, openjdk:11-jre, openjdk:latest
# Uses intermediate image for building Drill to reduce target image size
-FROM maven:3.6.3-jdk-8 as build
+FROM maven:3.8.2-openjdk-11 as build
Review comment:
Oh I better check this, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vvysotskyi commented on pull request #2317: DRILL-7999 Base Docker image on maven:3.8.2-jdk-11 and openjdk-11
Posted by GitBox <gi...@apache.org>.
vvysotskyi commented on pull request #2317:
URL: https://github.com/apache/drill/pull/2317#issuecomment-921793495
@dzamo, see my comment above.
Regarding access to DockerHub repo, I think committers also can obtain it by creating a ticket to infra, specifying the username and reason for obtaining access.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vvysotskyi commented on a change in pull request #2317: DRILL-7999 Base Docker image on maven:3.8.2-jdk-11 and openjdk-11
Posted by GitBox <gi...@apache.org>.
vvysotskyi commented on a change in pull request #2317:
URL: https://github.com/apache/drill/pull/2317#discussion_r710320589
##########
File path: hooks/build
##########
@@ -0,0 +1,4 @@
+docker build --build-arg BASE_IMAGE=openjdk:8-jre -t apache/drill:latest .
+docker build --build-arg BASE_IMAGE=openjdk:11-jre -t apache/drill:openjdk11 .
+docker build --build-arg BASE_IMAGE=openjdk:17 -t apache/drill:openjdk17 .
Review comment:
We don't support JDK 17 yet: https://github.com/apache/drill/blob/master/.github/workflows/ci.yml#L36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] dzamo commented on a change in pull request #2317: DRILL-7999 Base Docker image on maven:3.8.2-jdk-11 and openjdk-11
Posted by GitBox <gi...@apache.org>.
dzamo commented on a change in pull request #2317:
URL: https://github.com/apache/drill/pull/2317#discussion_r710098864
##########
File path: Dockerfile
##########
@@ -16,31 +16,53 @@
# limitations under the License.
#
-# This Dockerfile is used for automated builds in DockerHub. It adds project sources into the build image, builds
-# Drill and copies built binaries into the target image based on openjdk:8u232-jdk image.
+# This Dockerfile is used for automated builds in DockerHub. It adds
+# project sources into the build image, builds Drill and copies built
+# binaries into the target image based on the image name in BASE_NAME
+# env var which you should set when invoking docker build.
+# Example BASE_NAME values: openjdk:8-jre, openjdk:11-jre, openjdk:latest
# Uses intermediate image for building Drill to reduce target image size
-FROM maven:3.6.3-jdk-8 as build
+FROM maven:3.8.2-openjdk-11 as build
Review comment:
Reverted the build container to OpenJDK 8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vvysotskyi commented on pull request #2317: DRILL-7999 Base Docker image on maven:3.8.2-jdk-11 and openjdk-11
Posted by GitBox <gi...@apache.org>.
vvysotskyi commented on pull request #2317:
URL: https://github.com/apache/drill/pull/2317#issuecomment-921779241
@cgivre, we have investigated it some time ago and it cannot be done, please see this ticket: https://issues.apache.org/jira/browse/INFRA-19810
But we can add a badge for DockerHub into the root README.md: https://github.com/badges/shields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] dzamo commented on pull request #2317: Base Docker image on maven:3.8.2-jdk-11 and openjdk-11.
Posted by GitBox <gi...@apache.org>.
dzamo commented on pull request #2317:
URL: https://github.com/apache/drill/pull/2317#issuecomment-920219533
@vvysotskyi had a great idea of turning the base openjdk image name in the Dockerfile into a variable so that we can build and publish for a few different JDK versions with this one Dockerfile. So please don't merge this until I return with that enhancement, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vvysotskyi commented on a change in pull request #2317: DRILL-7999 Base Docker image on maven:3.8.2-jdk-11 and openjdk-11
Posted by GitBox <gi...@apache.org>.
vvysotskyi commented on a change in pull request #2317:
URL: https://github.com/apache/drill/pull/2317#discussion_r710157786
##########
File path: Dockerfile
##########
@@ -16,31 +16,43 @@
# limitations under the License.
#
-# This Dockerfile is used for automated builds in DockerHub. It adds project sources into the build image, builds
-# Drill and copies built binaries into the target image based on openjdk:8u232-jdk image.
+# This Dockerfile is used for automated builds in DockerHub. It adds
+# project sources into the build image, builds Drill and copies built
+# binaries into the target image based on the image name in BASE_IMAGE
+# build arg which you should set when invoking docker build.
+# Example syntax: docker build --build-arg BASE_IMAGE="openjdk:8-jre"
-# Uses intermediate image for building Drill to reduce target image size
-FROM maven:3.6.3-jdk-8 as build
+ARG $BASE_IMAGE=openjdk:11-jre
Review comment:
Please use JDK 8 as a default one.
##########
File path: Dockerfile
##########
@@ -16,31 +16,43 @@
# limitations under the License.
#
-# This Dockerfile is used for automated builds in DockerHub. It adds project sources into the build image, builds
-# Drill and copies built binaries into the target image based on openjdk:8u232-jdk image.
+# This Dockerfile is used for automated builds in DockerHub. It adds
+# project sources into the build image, builds Drill and copies built
+# binaries into the target image based on the image name in BASE_IMAGE
+# build arg which you should set when invoking docker build.
+# Example syntax: docker build --build-arg BASE_IMAGE="openjdk:8-jre"
-# Uses intermediate image for building Drill to reduce target image size
-FROM maven:3.6.3-jdk-8 as build
+ARG $BASE_IMAGE=openjdk:11-jre
-# Copy project sources into the container
-COPY . /src
+# Uses intermediate image for building Drill to reduce target image size
+# Build using OpenJDK 8 to maintain compatibility with all OpenJDK >= 8
+FROM maven:3.8.2-openjdk-8 as build
Review comment:
It can be made configurable too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vvysotskyi commented on a change in pull request #2317: DRILL-7999 Base Docker image on maven:3.8.2-jdk-11 and openjdk-11
Posted by GitBox <gi...@apache.org>.
vvysotskyi commented on a change in pull request #2317:
URL: https://github.com/apache/drill/pull/2317#discussion_r710082331
##########
File path: Dockerfile
##########
@@ -16,31 +16,53 @@
# limitations under the License.
#
-# This Dockerfile is used for automated builds in DockerHub. It adds project sources into the build image, builds
-# Drill and copies built binaries into the target image based on openjdk:8u232-jdk image.
+# This Dockerfile is used for automated builds in DockerHub. It adds
+# project sources into the build image, builds Drill and copies built
+# binaries into the target image based on the image name in BASE_NAME
+# env var which you should set when invoking docker build.
+# Example BASE_NAME values: openjdk:8-jre, openjdk:11-jre, openjdk:latest
# Uses intermediate image for building Drill to reduce target image size
-FROM maven:3.6.3-jdk-8 as build
+FROM maven:3.8.2-openjdk-11 as build
+
+WORKDIR /src
# Copy project sources into the container
-COPY . /src
+COPY . .
-WORKDIR /src
+# Optimisation: build a selection of Drill modules in advance.
+# It isn't necessary to build any modules independently but doing so divides
+# the downloading and compiling up over multiple cacheable layers, better
+# enabling reuse in the event of an isolated change and resume in the event
+# of a build error. This paragraph can safely be commented out.
+RUN mvn -am -pl tools -Dmaven.artifact.threads=5 -T1C install -DskipTests
+RUN mvn -am -pl protocol -Dmaven.artifact.threads=5 -T1C install -DskipTests
+RUN mvn -am -pl common -Dmaven.artifact.threads=5 -T1C install -DskipTests
+RUN mvn -am -pl logical -Dmaven.artifact.threads=5 -T1C install -DskipTests
+RUN mvn -am -pl exec -Dmaven.artifact.threads=5 -T1C install -DskipTests
+RUN mvn -am -pl drill-yarn -Dmaven.artifact.threads=5 -T1C install -DskipTests
+RUN mvn -am -pl distribution -Dmaven.artifact.threads=5 -T1C install -DskipTests
# Builds Drill
-RUN mvn clean install -DskipTests -q
+RUN mvn -Dmaven.artifact.threads=5 -T1C install -DskipTests
# Get project version and copy built binaries into /opt/drill directory
RUN VERSION=$(mvn -q -Dexec.executable=echo -Dexec.args='${project.version}' --non-recursive exec:exec) \
&& mkdir /opt/drill \
&& mv distribution/target/apache-drill-${VERSION}/apache-drill-${VERSION}/* /opt/drill
# Target image
-FROM openjdk:8u232-jdk
-RUN mkdir /opt/drill
+# Set the BASE_IMAGE env var when you invoke docker build.
+FROM $BASE_IMAGE
Review comment:
Please assign a default value for `BASE_IMAGE` to preserve backward compatibility when building images without specifying env variables.
##########
File path: Dockerfile
##########
@@ -16,31 +16,53 @@
# limitations under the License.
#
-# This Dockerfile is used for automated builds in DockerHub. It adds project sources into the build image, builds
-# Drill and copies built binaries into the target image based on openjdk:8u232-jdk image.
+# This Dockerfile is used for automated builds in DockerHub. It adds
+# project sources into the build image, builds Drill and copies built
+# binaries into the target image based on the image name in BASE_NAME
+# env var which you should set when invoking docker build.
+# Example BASE_NAME values: openjdk:8-jre, openjdk:11-jre, openjdk:latest
# Uses intermediate image for building Drill to reduce target image size
-FROM maven:3.6.3-jdk-8 as build
+FROM maven:3.8.2-openjdk-11 as build
Review comment:
Are you sure that jars built using JDK 11 will be running fine on JDB 8?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] dzamo edited a comment on pull request #2317: DRILL-7999 Base Docker image on maven:3.8.2-jdk-11 and openjdk-11
Posted by GitBox <gi...@apache.org>.
dzamo edited a comment on pull request #2317:
URL: https://github.com/apache/drill/pull/2317#issuecomment-920894974
@vvysotskyi I'm just stuck with the DockerHub builds. In my personal account the Builds tab shows
> Available on Pro and Team plans.
If there is a way to share the Drill account login for DockerHub I am happy to go and experiement there. I did convert the `BASE_IMAGE` variable to a build arg in my recent changes so we need build invocations like:
```
docker build --build-arg BASE_IMAGE=openjdk:8-jre -t apache/drill:openjdk8...
docker build --build-arg BASE_IMAGE=openjdk:11-jre -t apache/drill:openjdk11 ...
docker build --build-arg BASE_IMAGE=openjdk:latest -t apache/drill:openjdk-latest ...
```
where we need to make some decisions about the tags we apply and what becomes of `apache/drill:latest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] dzamo merged pull request #2317: DRILL-7999 Base Docker image on maven:3.8.2-jdk-11 and openjdk-11
Posted by GitBox <gi...@apache.org>.
dzamo merged pull request #2317:
URL: https://github.com/apache/drill/pull/2317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] dzamo commented on pull request #2317: DRILL-7999 Base Docker image on maven:3.8.2-jdk-11 and openjdk-11
Posted by GitBox <gi...@apache.org>.
dzamo commented on pull request #2317:
URL: https://github.com/apache/drill/pull/2317#issuecomment-920894974
@vvysotskyi I'm just stuck with the DockerHub builds. In my personal account the Builds tab shows
> Available on Pro and Team plans.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] dzamo commented on pull request #2317: DRILL-7999 Base Docker image on maven:3.8.2-jdk-11 and openjdk-11
Posted by GitBox <gi...@apache.org>.
dzamo commented on pull request #2317:
URL: https://github.com/apache/drill/pull/2317#issuecomment-922336140
I finally got to the bottom of
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:3.2.0:single (distro-assembly) on project distribution: Failed to create assembly: Error adding file to archive: /src/distribution/../git.properties -> [Help 1]
```
It came from adding .git/ to .dockerignore. Turns out one can't build without the git repository there because of the git-commit-id plugin. Here's hoping some new image tags will show up in Docker Hub in the next couple of hours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on pull request #2317: DRILL-7999 Base Docker image on maven:3.8.2-jdk-11 and openjdk-11
Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2317:
URL: https://github.com/apache/drill/pull/2317#issuecomment-921752835
@dzamo I have a silly request for DockerHub as well... If this is the "official" Drill container, could you see if you could add the logo to DockerHub?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vvysotskyi commented on a change in pull request #2317: DRILL-7999 Base Docker image on maven:3.8.2-jdk-11 and openjdk-11
Posted by GitBox <gi...@apache.org>.
vvysotskyi commented on a change in pull request #2317:
URL: https://github.com/apache/drill/pull/2317#discussion_r710904164
##########
File path: hooks/build
##########
@@ -0,0 +1,38 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+docker build \
+ --build-arg BUILD_BASE_IMAGE=maven:3.8.2-openjdk-8 \
+ --build-arg BASE_IMAGE=openjdk:8-jre \
+ -t apache/drill:openjdk-8 \
+ -t apache/drill:latest \
Review comment:
Just recalled the latest tag is not published for the master version. It is published for release only, so please delete it here. We use the `master` tag for builds from the master branch. The good news is that according to https://docs.docker.com/docker-hub/builds/advanced/#environment-variables-for-building-and-testing, we can use tag name from the dockerhub configuration: `DOCKER_TAG`, so please replace `latest` with that value, and add this variable to tag names with open-jdk, so we will have something like `$DOCKER_TAG-openjdk:8-jre` that will become `master-openjdk:8-jre` or `latest-openjdk:8-jre` or `1.20.0-openjdk:8-jre` for the release.
##########
File path: hooks/push
##########
@@ -0,0 +1,21 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+docker push apache/drill:openjdk-8
+docker push apache/drill:openjdk-11
+docker push apache/drill:openjdk-14
Review comment:
Please also use `DOCKER_TAG` var here, and add one more line to push `apache/drill:$DOCKER_TAG` (tag without openjdk suffix)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] dzamo commented on pull request #2317: DRILL-7999 Base Docker image on maven:3.8.2-jdk-11 and openjdk-11
Posted by GitBox <gi...@apache.org>.
dzamo commented on pull request #2317:
URL: https://github.com/apache/drill/pull/2317#issuecomment-921638280
> It fails on DockerHub:
>
> > Executing build hook...
> > Could not execute hook at 'hooks/build'. Is it missing a #! line?
Added the shebang. And I checked that the two hooks have the executable perm set for all users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] dzamo commented on pull request #2317: DRILL-7999 Base Docker image on maven:3.8.2-jdk-11 and openjdk-11
Posted by GitBox <gi...@apache.org>.
dzamo commented on pull request #2317:
URL: https://github.com/apache/drill/pull/2317#issuecomment-921586463
@luocooong I rebased on master but I see my latest Travis CI ARM64 build failed. Most informative line I saw in the logs
> [ERROR] Exception: java.lang.OutOfMemoryError thrown from the UncaughtExceptionHandler in thread "WorkManager.StatusThread"
Is it something we already know of? I am not very knowledgeable about tweaking the build but if there's anything I can help with let me know...
cc @vdiravka
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vvysotskyi commented on pull request #2317: DRILL-7999 Base Docker image on maven:3.8.2-jdk-11 and openjdk-11
Posted by GitBox <gi...@apache.org>.
vvysotskyi commented on pull request #2317:
URL: https://github.com/apache/drill/pull/2317#issuecomment-920941467
@dzamo, ok, thanks for the clarification, I didn't expect that it is not available for a free account.
Regarding the latest, let's leave JDK 8 as it is now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vvysotskyi commented on pull request #2317: DRILL-7999 Base Docker image on maven:3.8.2-jdk-11 and openjdk-11
Posted by GitBox <gi...@apache.org>.
vvysotskyi commented on pull request #2317:
URL: https://github.com/apache/drill/pull/2317#issuecomment-921626641
Also, please squash commits and update the commit message to include the ticket number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] dzamo commented on pull request #2317: DRILL-7999 Base Docker image on maven:3.8.2-jdk-11 and openjdk-11
Posted by GitBox <gi...@apache.org>.
dzamo commented on pull request #2317:
URL: https://github.com/apache/drill/pull/2317#issuecomment-921779380
> @dzamo I have a silly request for DockerHub as well... If this is the "official" Drill container, could you see if you could add the logo to DockerHub?
@cgivre for sure. I'll ask @vvysotskyi for help here since I think he's the only one of us with access. We should probably get at least one more of us access there, maybe ideally one in a distinct time zone. Is it more of thing that the PMC members cover? I don't mind putting my hand up if not, and then I can sort out the logo once I'm added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org