[GitHub] [helix] pkuwm commented on issue #567: Revert "Deep copy for mapFields and listFields in ZNRecord's copy constructor. (#552)"

[GitBox <gi...@apache.org>]

pkuwm commented on issue #567: Revert "Deep copy for mapFields and listFields in ZNRecord's copy constructor. (#552)"
URL: https://github.com/apache/helix/pull/567#issuecomment-549634564
 
 
   Tests are all passed.
   
   This PR is ready to be merged, approved by @dasahcc 
   commit message:
   ```
   Revert "Deep copy for mapFields and listFields in ZNRecord's copy constructor."
   This reverts commit 2a335cf.
   The copy constructor in ZNRecord is critical. It may cause potential concurrency problems like race condition in other methods. To be safe, we don't want deep copy.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org