[GitHub] geertjanw closed pull request #530: [NETBEANS-373] Removing synchronization from refactoring dialog.

[GitBox <gi...@apache.org>]

geertjanw closed pull request #530: [NETBEANS-373] Removing synchronization from refactoring dialog.
URL: https://github.com/apache/incubator-netbeans/pull/530
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/refactoring.api/src/org/netbeans/modules/refactoring/spi/impl/ParametersPanel.java b/refactoring.api/src/org/netbeans/modules/refactoring/spi/impl/ParametersPanel.java
index 26a248bc2..c29f4f006 100644
--- a/refactoring.api/src/org/netbeans/modules/refactoring/spi/impl/ParametersPanel.java
+++ b/refactoring.api/src/org/netbeans/modules/refactoring/spi/impl/ParametersPanel.java
@@ -349,7 +349,6 @@ private void backActionPerformed(java.awt.event.ActionEvent evt) {//GEN-FIRST:ev
     }//GEN-LAST:event_backActionPerformed
 
     private void cancelActionPerformed(java.awt.event.ActionEvent evt) {//GEN-FIRST:event_cancelActionPerformed
-        synchronized (this) {
             canceledDialog = true;
             if (evt != null && evt.getSource() instanceof Cancellable) {
                 putResult(null);
@@ -365,7 +364,6 @@ private void cancelActionPerformed(java.awt.event.ActionEvent evt) {//GEN-FIRST:
                 }
                 cancelRequest = true;
             }
-        }
     }//GEN-LAST:event_cancelActionPerformed
     private void refactor(final boolean previewAll) {
         LOGGER.log(Level.FINEST, "refactor - currentState={0}", currentState);
@@ -587,7 +585,7 @@ private void disableComponents(Container c) {
      * operation or
      * <code>null</code> if the operation was cancelled.
      */
-    public synchronized RefactoringSession showDialog() {
+    public RefactoringSession showDialog() {
         RefactoringPanel.checkEventThread();
         putClientProperty(JUMP_TO_FIRST_OCCURENCE, false);
         if (rui != null) {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists