You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "danielcweber (GitHub)" <gi...@apache.org> on 2018/10/26 14:32:59 UTC

[GitHub] [tinkerpop] danielcweber opened pull request #972: TINKERPOP-2067 Allow getting raw JToken data from Gremlin.Net.Driver.GremlinClient.

https://issues.apache.org/jira/browse/TINKERPOP-2067


[ Full content available at: https://github.com/apache/tinkerpop/pull/972 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] FlorianHockmann closed pull request #972: TINKERPOP-2067 Allow getting raw JToken data from Gremlin.Net.Driver.GremlinClient.

Posted by "FlorianHockmann (GitHub)" <gi...@apache.org>.
[ pull request closed by FlorianHockmann ]

[ Full content available at: https://github.com/apache/tinkerpop/pull/972 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] danielcweber commented on pull request #972: TINKERPOP-2067 Allow getting raw JToken data from Gremlin.Net.Driver.GremlinClient.

Posted by "danielcweber (GitHub)" <gi...@apache.org>.
Done, more assertions now!

[ Full content available at: https://github.com/apache/tinkerpop/pull/972 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] FlorianHockmann commented on pull request #972: TINKERPOP-2067 Allow getting raw JToken data from Gremlin.Net.Driver.GremlinClient.

Posted by "FlorianHockmann (GitHub)" <gi...@apache.org>.
I'm not sure but wouldn't this test also succeed without your change as the returned data is just a string here? Maybe it would make more sense to return something that includes a type in its GraphSON form like an `int`?

[ Full content available at: https://github.com/apache/tinkerpop/pull/972 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] FlorianHockmann commented on pull request #972: TINKERPOP-2067 Allow getting raw JToken data from Gremlin.Net.Driver.GremlinClient.

Posted by "FlorianHockmann (GitHub)" <gi...@apache.org>.
Another nit, please rename the test to be consistent with the other ones, e.g., no underscores (except when they just describe the tested traversal which isn't the case here) and the test name could a bit more specific. How about something like `ShouldReturnResultWithoutDeserializingItForJTokenType`?

[ Full content available at: https://github.com/apache/tinkerpop/pull/972 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] danielcweber commented on pull request #972: TINKERPOP-2067 Allow getting raw JToken data from Gremlin.Net.Driver.GremlinClient.

Posted by "danielcweber (GitHub)" <gi...@apache.org>.
Done.

[ Full content available at: https://github.com/apache/tinkerpop/pull/972 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] FlorianHockmann commented on pull request #972: TINKERPOP-2067 Allow getting raw JToken data from Gremlin.Net.Driver.GremlinClient.

Posted by "FlorianHockmann (GitHub)" <gi...@apache.org>.
Just a nit, but could you assert here that `"someString"` gets returned (like it's done in the `ShouldSendScriptForEvaluationAndReturnCorrectResult` test)?

[ Full content available at: https://github.com/apache/tinkerpop/pull/972 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] danielcweber commented on pull request #972: TINKERPOP-2067 Allow getting raw JToken data from Gremlin.Net.Driver.GremlinClient.

Posted by "danielcweber (GitHub)" <gi...@apache.org>.
It would not anymore since there's more assertions now about the actual JObject that's returned, which is not just a plain string but

    {
        "@type": "g:List",
        "@value": [
            "someString"
         ]
    }

[ Full content available at: https://github.com/apache/tinkerpop/pull/972 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on issue #972: TINKERPOP-2067 Allow getting raw JToken data from Gremlin.Net.Driver.GremlinClient.

Posted by "spmallette (GitHub)" <gi...@apache.org>.
VOTE +1 

@FlorianHockmann will you be handling this merge? if not, i can do it...

[ Full content available at: https://github.com/apache/tinkerpop/pull/972 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] FlorianHockmann commented on issue #972: TINKERPOP-2067 Allow getting raw JToken data from Gremlin.Net.Driver.GremlinClient.

Posted by "FlorianHockmann (GitHub)" <gi...@apache.org>.
Sure, I can take care of the merge, but if you want to do it, then by all means go ahead! It's not like I own the code or anything 😅

[ Full content available at: https://github.com/apache/tinkerpop/pull/972 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] dkuppitz commented on issue #972: TINKERPOP-2067 Allow getting raw JToken data from Gremlin.Net.Driver.GremlinClient.

Posted by "dkuppitz (GitHub)" <gi...@apache.org>.
VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/972 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] FlorianHockmann commented on pull request #972: TINKERPOP-2067 Allow getting raw JToken data from Gremlin.Net.Driver.GremlinClient.

Posted by "FlorianHockmann (GitHub)" <gi...@apache.org>.
Hmm, didn't realize that the result would be wrapped in a list in cases like this, but you obviously proved that it's the case with the added asserts.

[ Full content available at: https://github.com/apache/tinkerpop/pull/972 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org