[jira] [Commented] (TINKERPOP-2028) AbstractGraphSONMessageSerializerV2d0 should register GremlinServerModule when mapper is provided

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603345#comment-16603345 ] 

ASF GitHub Bot commented on TINKERPOP-2028:
-------------------------------------------

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/923
  
    This seems to build now along with gremlin server integration tests. Any reason to not go to `tp33`? if not, please squash and retarget and i can go ahead an move to merge.
    
    Please also take a look at adding `final` to variables where needed.  A CHANGELOG entry might be good too. 
    
    Thanks for this.
    
    VOTE +1


> AbstractGraphSONMessageSerializerV2d0 should register GremlinServerModule when mapper is provided
> -------------------------------------------------------------------------------------------------
>
>                 Key: TINKERPOP-2028
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2028
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 3.3.1, 3.2.9
>            Reporter: Kevin Gallardo
>            Priority: Major
>
> When specifying a {{GraphSONMapper}} when constructing a {{GraphSONMessageSerializerV3d0}}, the Message serializer will not register any module. Hence users will have to manually register the {{GremlinServerModule}} to the GraphSONMapper they are giving in parameter for it to work at all:
> {code:java}
> GraphSONMessageSerializerV3d0 messageSerializerV3d0 =
>     new GraphSONMessageSerializerV3d0(
>         GraphSONMapper.build()
>             .version(GraphSONVersion.V3_0)
>             .addCustomModule(new 
> AbstractGraphSONMessageSerializerV2d0.GremlinServerModule())
>             .addRegistry(TinkerIoRegistryV3d0.instance()).create());
> {code}
> When not providing a Mapper, the GremlinServerModule is registered automatically. It sounds reasonable in the context of the {{GraphSONMessageSerializer}} to automatically register the {{GremlinServerModule}} wdyt?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)