You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/10/26 16:11:24 UTC
[PR] Object tagging (#4754) [arrow-rs]
tustvold opened a new pull request, #4999:
URL: https://github.com/apache/arrow-rs/pull/4999
_Draft as builds on #4984 and I think it should be possible to configure stores to ignore tags_
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Some stores support object tagging and this is important for existing workloads. Unfortunately support for this is not supported at all in some cases, e.g. GCS, and inconsistently supported in others, e.g. Azure and AWS-compatible stores.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Object tagging (#4754) [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4999:
URL: https://github.com/apache/arrow-rs/pull/4999#discussion_r1374709660
##########
object_store/src/aws/builder.rs:
##########
@@ -299,6 +301,15 @@ pub enum AmazonS3ConfigKey {
/// Skip signing request
SkipSignature,
+ /// Skips tagging objects
+ ///
+ /// This can be desirable if not supported by the backing store
+ ///
+ /// Supported keys:
+ /// - `aws_skip_tagging`
+ /// - `skip_tagging`
+ SkipTagging,
Review Comment:
I don't feel strongly about this name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Object tagging (#4754) [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4999:
URL: https://github.com/apache/arrow-rs/pull/4999#discussion_r1374490663
##########
object_store/src/lib.rs:
##########
@@ -1882,6 +1903,63 @@ mod tests {
assert_eq!(meta.size, chunk_size * 2);
}
+ #[cfg(any(feature = "aws", feature = "azure"))]
+ pub(crate) async fn tagging<F, Fut>(storage: &dyn ObjectStore, get_tags: F)
+ where
+ F: Fn(Path) -> Fut + Send + Sync,
+ Fut: Future<Output = Result<reqwest::Response>> + Send,
Review Comment:
Honestly working out the correct combination of lifetimes and send and sync took longer than anything else in this PR... Sometimes I really dislike async...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Object tagging (#4754) [arrow-rs]
Posted by "thinkharderdev (via GitHub)" <gi...@apache.org>.
thinkharderdev commented on code in PR #4999:
URL: https://github.com/apache/arrow-rs/pull/4999#discussion_r1374748745
##########
object_store/src/aws/builder.rs:
##########
@@ -299,6 +301,15 @@ pub enum AmazonS3ConfigKey {
/// Skip signing request
SkipSignature,
+ /// Skips tagging objects
+ ///
+ /// This can be desirable if not supported by the backing store
+ ///
+ /// Supported keys:
+ /// - `aws_skip_tagging`
+ /// - `skip_tagging`
+ SkipTagging,
Review Comment:
Maybe `DisableTagging`
##########
object_store/src/aws/builder.rs:
##########
@@ -299,6 +301,15 @@ pub enum AmazonS3ConfigKey {
/// Skip signing request
SkipSignature,
+ /// Skips tagging objects
+ ///
+ /// This can be desirable if not supported by the backing store
+ ///
+ /// Supported keys:
+ /// - `aws_skip_tagging`
+ /// - `skip_tagging`
+ SkipTagging,
Review Comment:
but I don't feel strongly either :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Object tagging (#4754) [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4999:
URL: https://github.com/apache/arrow-rs/pull/4999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org