[jira] [Commented] (AIRFLOW-6557) Warn if new fields are added to BaseOperator (for serialization)

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17015103#comment-17015103 ] 

ASF GitHub Bot commented on AIRFLOW-6557:
-----------------------------------------

potiuk commented on pull request #7162: [AIRFLOW-6557] Add test for newly added fields in BaseOperator
URL: https://github.com/apache/airflow/pull/7162
 
 
   Adding new field in BaseOperator requires some manual updates
   in serialization code. This test detects new fields and informs
   what should be done in case new field is added.
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Warn if new fields are added to BaseOperator (for serialization)
> ----------------------------------------------------------------
>
>                 Key: AIRFLOW-6557
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6557
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: serialization, tests
>    Affects Versions: 2.0.0
>            Reporter: Jarek Potiuk
>            Priority: Major
>
> There should be an automated tests that tells people what to do in case they add field in BaseOperator. The test should fail and explain how serialisation should be updated.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)