You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/30 12:03:40 UTC

[GitHub] [flink] docete opened a new pull request #10723: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/TimestampMinAggFunction to accept LocalDateTime values

docete opened a new pull request #10723: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/TimestampMinAggFunction to accept LocalDateTime values
URL: https://github.com/apache/flink/pull/10723
 
 
   ## What is the purpose of the change
   
   The MaxWithRetractAggFunction/MinWithRetractAggFunction in blink planner not support "accumulate(acc, Object value)" generic object with third-part data formats. We only support internal/external format in this usage. In this PR, we use LocalDateTime(the default external format of TimestampType) in TimestampMaxAggFunction/TimestampMinAggFunction to fix the ClassCastException. This PR **only fix release 1.9**. For release 1.10 or above, see https://github.com/apache/flink/pull/10722
   
   ## Brief change log
   
   - b0bd11c use LocalDateTime in `TimestampMaxAggFunction` and `TimestampMinAggFunction`
   
   ## Verifying this change
   
   This change added tests 
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (**yes** / no)
     - If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on issue #10723: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/TimestampMinAggFunction to accept LocalDateTime values

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #10723: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/TimestampMinAggFunction to accept LocalDateTime values
URL: https://github.com/apache/flink/pull/10723#issuecomment-569847722
 
 
   LGTM +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10723: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/TimestampMinAggFunction to accept LocalDateTime values

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10723: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/TimestampMinAggFunction to accept LocalDateTime values
URL: https://github.com/apache/flink/pull/10723#issuecomment-569667691
 
 
   <!--
   Meta data
   Hash:b0bd11c0eed984303716ce77ca8e141b381ead7f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142641869 TriggerType:PUSH TriggerID:b0bd11c0eed984303716ce77ca8e141b381ead7f
   Hash:21ba143267df49e557cc2839c1217dcaa2b1f03f Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:21ba143267df49e557cc2839c1217dcaa2b1f03f
   -->
   ## CI report:
   
   * b0bd11c0eed984303716ce77ca8e141b381ead7f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142641869) 
   * 21ba143267df49e557cc2839c1217dcaa2b1f03f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10723: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/TimestampMinAggFunction to accept LocalDateTime values

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10723: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/TimestampMinAggFunction to accept LocalDateTime values
URL: https://github.com/apache/flink/pull/10723#issuecomment-569667691
 
 
   <!--
   Meta data
   Hash:b0bd11c0eed984303716ce77ca8e141b381ead7f Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:b0bd11c0eed984303716ce77ca8e141b381ead7f
   -->
   ## CI report:
   
   * b0bd11c0eed984303716ce77ca8e141b381ead7f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong merged pull request #10723: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/TimestampMinAggFunction to accept LocalDateTime values

Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #10723: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/TimestampMinAggFunction to accept LocalDateTime values
URL: https://github.com/apache/flink/pull/10723
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10723: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/TimestampMinAggFunction to accept LocalDateTime values

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10723: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/TimestampMinAggFunction to accept LocalDateTime values
URL: https://github.com/apache/flink/pull/10723#issuecomment-569667691
 
 
   <!--
   Meta data
   Hash:b0bd11c0eed984303716ce77ca8e141b381ead7f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142641869 TriggerType:PUSH TriggerID:b0bd11c0eed984303716ce77ca8e141b381ead7f
   Hash:21ba143267df49e557cc2839c1217dcaa2b1f03f Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142644170 TriggerType:PUSH TriggerID:21ba143267df49e557cc2839c1217dcaa2b1f03f
   -->
   ## CI report:
   
   * b0bd11c0eed984303716ce77ca8e141b381ead7f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142641869) 
   * 21ba143267df49e557cc2839c1217dcaa2b1f03f Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142644170) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10723: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/TimestampMinAggFunction to accept LocalDateTime values

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10723: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/TimestampMinAggFunction to accept LocalDateTime values
URL: https://github.com/apache/flink/pull/10723#issuecomment-569667691
 
 
   <!--
   Meta data
   Hash:b0bd11c0eed984303716ce77ca8e141b381ead7f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142641869 TriggerType:PUSH TriggerID:b0bd11c0eed984303716ce77ca8e141b381ead7f
   Hash:21ba143267df49e557cc2839c1217dcaa2b1f03f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142644170 TriggerType:PUSH TriggerID:21ba143267df49e557cc2839c1217dcaa2b1f03f
   -->
   ## CI report:
   
   * b0bd11c0eed984303716ce77ca8e141b381ead7f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142641869) 
   * 21ba143267df49e557cc2839c1217dcaa2b1f03f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142644170) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10723: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/TimestampMinAggFunction to accept LocalDateTime values

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10723: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/TimestampMinAggFunction to accept LocalDateTime values
URL: https://github.com/apache/flink/pull/10723#issuecomment-569660486
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit b0bd11c0eed984303716ce77ca8e141b381ead7f (Mon Dec 30 12:06:12 UTC 2019)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services